You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/11/02 08:18:21 UTC
[GitHub] [commons-cli] chingjustwe opened a new pull request, #143: Change method visibility
chingjustwe opened a new pull request, #143:
URL: https://github.com/apache/commons-cli/pull/143
Change the visibility of method `handleUnknownToken()` to `protected`, give end engineer a change to handle such case themselves (I just need to ignore the exception `ParseException` here 😃).
> Since I do not find the **Issues** tab to raise an issue, so I just created a PR myself, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-cli] garydgregory commented on pull request #143: Change method visibility
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #143:
URL: https://github.com/apache/commons-cli/pull/143#issuecomment-1504055120
Then an example as a test would be beneficial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-cli] garydgregory commented on pull request #143: Change method visibility
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #143:
URL: https://github.com/apache/commons-cli/pull/143#issuecomment-1678081672
Closing: No reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-cli] garydgregory closed pull request #143: Change method visibility
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory closed pull request #143: Change method visibility
URL: https://github.com/apache/commons-cli/pull/143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-cli] garydgregory commented on pull request #143: Change method visibility
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #143:
URL: https://github.com/apache/commons-cli/pull/143#issuecomment-1500342942
@chingjustwe ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-cli] chingjustwe commented on pull request #143: Change method visibility
Posted by "chingjustwe (via GitHub)" <gi...@apache.org>.
chingjustwe commented on PR #143:
URL: https://github.com/apache/commons-cli/pull/143#issuecomment-1502857973
@garydgregory sorry for late reply...the use case for us is:
There is a monitoring platform, which allows users to provide their own java plugins to run some checks, we use `apache-commons-cli` to parse the input parameters, such as `--param1 "value1" --param2 "value2"`. We need to have the torrent to let users input unrecognized parameters, like `--param1 "value1" -oops "unrecognized" --param2 "value2"`, what we want here is just leave a warning message (unrecognized parameter "oops") and proceed. Changing the visibility of method `handleUnknownToken()` would give us such a chance to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-cli] garydgregory commented on pull request #143: Change method visibility
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #143:
URL: https://github.com/apache/commons-cli/pull/143#issuecomment-1302182387
@chingjustwe
Thank you for your PR. You should provide a test that showcases this use case to make sure it's the best path forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org