[GitHub] [hudi] danny0405 commented on a diff in pull request #8944: [HUDI-6359]Spark offline compaction/clustering will never rollback when both requested and inflight states exist

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #8944:
URL: https://github.com/apache/hudi/pull/8944#discussion_r1228874360


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieClusteringJob.java:
##########
@@ -209,8 +209,7 @@ private int doCluster(JavaSparkContext jsc) throws Exception {
         // Instant time is not specified
         // Find the earliest scheduled clustering instant for execution
         Option<HoodieInstant> firstClusteringInstant =
-            metaClient.getActiveTimeline().firstInstant(
-                HoodieTimeline.REPLACE_COMMIT_ACTION, HoodieInstant.State.REQUESTED);
+            metaClient.getActiveTimeline().filterPendingReplaceTimeline().firstInstant();

Review Comment:
   But how could we know that the instant in pending state is sill executing or already finished? There could be multiple offline compaction/clustering jobs running concurrently.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org