You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "ikun-Lg (via GitHub)" <gi...@apache.org> on 2024/05/08 13:04:33 UTC
[PR] front：Optimizing style codes and adding necessary code for instance detail pages [dubbo-kubernetes]
ikun-Lg opened a new pull request, #277:
URL: https://github.com/apache/dubbo-kubernetes/pull/277
task：
1. Extract common duplicate code and improve global style management
2. Simulate requests using mock and render data to the instance details page
3. add header component for tab
<img width="1211" alt="image" src="https://github.com/apache/dubbo-kubernetes/assets/120859665/7ec2e181-3b5c-4b4e-bf66-92bf2cdcea13">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] front：Optimizing style codes and adding necessary code for instance detail pages [dubbo-kubernetes]
Posted by "jianyi-gronk (via GitHub)" <gi...@apache.org>.
jianyi-gronk commented on code in PR #277:
URL: https://github.com/apache/dubbo-kubernetes/pull/277#discussion_r1594881637
##########
ui-vue3/src/views/traffic/tagRule/tabs/formView.vue:
##########
@@ -117,7 +117,7 @@
>
<a-tag color="#2db7f5">version=v1</a-tag>
</a-space>
- </a-card>
+ </a-card >
Review Comment:
Is npm run prettier-format not executed? There are irregularities in some places, such as here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] front：Optimizing style codes and adding necessary code for instance detail pages [dubbo-kubernetes]
Posted by "ikun-Lg (via GitHub)" <gi...@apache.org>.
ikun-Lg commented on code in PR #277:
URL: https://github.com/apache/dubbo-kubernetes/pull/277#discussion_r1595193970
##########
ui-vue3/src/views/traffic/tagRule/tabs/formView.vue:
##########
@@ -117,7 +117,7 @@
>
<a-tag color="#2db7f5">version=v1</a-tag>
</a-space>
- </a-card>
+ </a-card >
Review Comment:
get
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] front：Optimizing style codes and adding necessary code for instance detail pages [dubbo-kubernetes]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj merged PR #277:
URL: https://github.com/apache/dubbo-kubernetes/pull/277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org