[GitHub] [openwhisk] rabbah commented on a change in pull request #4951: add defensive code for dealing with loadbalancer concurrency tracking

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #4951:
URL: https://github.com/apache/openwhisk/pull/4951#discussion_r477499064



##########
File path: common/scala/src/main/scala/org/apache/openwhisk/core/connector/MessageConsumer.scala
##########
@@ -213,7 +213,13 @@ class MessageFeed(description: String,
       outstandingMessages = outstandingMessages.tail
 
       if (logHandoff) logging.debug(this, s"processing $topic[$partition][$offset] ($occupancy/$handlerCapacity)")
-      handler(bytes)
+      handler(bytes).andThen {
+        {
+          case Failure(e) =>
+            logging.error(this, s"Failed to process message for topic $topic : $e  (stack trace included)")
+            e.printStackTrace()

Review comment:
       printing the stack this way excludes it from the logger formatting - is that intended? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org