You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "icexelloss (via GitHub)" <gi...@apache.org> on 2023/06/01 18:53:28 UTC
[GitHub] [arrow] icexelloss opened a new pull request, #35878: GH-35838: Fix asof join backpresure
icexelloss opened a new pull request, #35878:
URL: https://github.com/apache/arrow/pull/35878
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
To fix a bug in asof join backpresure handling.
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
This is reverting a bug introduced in GH-34391 on this line that breaks asof join backpresure
https://github.com/apache/arrow/pull/34392/files#diff-5493b6ae7ea2a4d5cfb581034c076e9c4be7608382168de6d1301ef67b6c01eeR1410
Also make the types of `InputState::Make` and `BackpresureController` constructor more strict
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
No. However code change simply reverts to the state before the bug was introduced and therefore is pretty safe. In the meantime @rtpsw is working on adding tests around this but I would like to merge this to unblock internal issues around this.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] icexelloss merged pull request #35878: GH-35838: [C++] Fix asof join backpresure
Posted by "icexelloss (via GitHub)" <gi...@apache.org>.
icexelloss merged PR #35878:
URL: https://github.com/apache/arrow/pull/35878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] icexelloss commented on pull request #35878: GH-35838: Fix asof join backpresure
Posted by "icexelloss (via GitHub)" <gi...@apache.org>.
icexelloss commented on PR #35878:
URL: https://github.com/apache/arrow/pull/35878#issuecomment-1572609985
cc @westonpace I prefer to merge this to unblock internal issues while @rtpsw works on adding the test if that is OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] icexelloss commented on pull request #35878: GH-35838: [C++] Fix asof join backpresure
Posted by "icexelloss (via GitHub)" <gi...@apache.org>.
icexelloss commented on PR #35878:
URL: https://github.com/apache/arrow/pull/35878#issuecomment-1572744822
@rtpsw In order to get the head into a non buggy state first. I will going to merge this so that @rtpsw can pull this and continue to work on testing + reducing confusion of the variable naming per discussions https://github.com/apache/arrow/pull/35874#discussion_r1213516786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rtpsw commented on a diff in pull request #35878: GH-35838: [C++] Fix asof join backpresure
Posted by "rtpsw (via GitHub)" <gi...@apache.org>.
rtpsw commented on code in PR #35878:
URL: https://github.com/apache/arrow/pull/35878#discussion_r1213627756
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -1407,7 +1407,7 @@ class AsofJoinNode : public ExecNode {
ARROW_ASSIGN_OR_RAISE(
auto input_state,
InputState::Make(i, tolerance_, must_hash_, may_rehash_, key_hashers_[i].get(),
- this, inputs[i], backpressure_counter_,
+ inputs[i], this, backpressure_counter_,
Review Comment:
Note that I have just added tests in #35874, though this PR can proceed, if so desired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #35878: GH-35838: [C++] Fix asof join backpresure
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #35878:
URL: https://github.com/apache/arrow/pull/35878#issuecomment-1573674585
@icexelloss makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] icexelloss commented on a diff in pull request #35878: GH-35838: Fix asof join backpresure
Posted by "icexelloss (via GitHub)" <gi...@apache.org>.
icexelloss commented on code in PR #35878:
URL: https://github.com/apache/arrow/pull/35878#discussion_r1213552182
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -1407,7 +1407,7 @@ class AsofJoinNode : public ExecNode {
ARROW_ASSIGN_OR_RAISE(
auto input_state,
InputState::Make(i, tolerance_, must_hash_, may_rehash_, key_hashers_[i].get(),
- this, inputs[i], backpressure_counter_,
+ inputs[i], this, backpressure_counter_,
Review Comment:
Simply reverting this line where the bug is introduced:
https://github.com/apache/arrow/pull/34392/files#diff-5493b6ae7ea2a4d5cfb581034c076e9c4be7608382168de6d1301ef67b6c01eeR1410
@rtpsw is working on adding tests but it could take some time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35878: GH-35838: [C++] Fix asof join backpresure
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35878:
URL: https://github.com/apache/arrow/pull/35878#issuecomment-1574593061
Benchmark runs are scheduled for baseline = 61692b69e4954f50ced110bf46dd92041748776f and contender = 3fe4a315633c2d959a1e1c069e15688db4d8e2d1. 3fe4a315633c2d959a1e1c069e15688db4d8e2d1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/1d42cf0f3a28412fb425b28e2b22028a...420203d0e26342f6b2a62b31fecb7be4/)
[Finished :arrow_down:0.56% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/76ec182de9a740bbb4d24884644d1da7...9c4c857ce0aa47efb8b80570c797612d/)
[Finished :arrow_down:0.98% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/01701b4a2331457b966152cab9b4de59...6646aacbc3714a1a8be7d1730f4009a8/)
[Finished :arrow_down:0.33% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/456f7e9db9a7442e9c504f6a41111175...c08006b7b9f14025a186edd3b6e73cf8/)
Buildkite builds:
[Finished] [`3fe4a315` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2971)
[Finished] [`3fe4a315` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3007)
[Finished] [`3fe4a315` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2972)
[Finished] [`3fe4a315` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2997)
[Finished] [`61692b69` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2970)
[Finished] [`61692b69` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3006)
[Finished] [`61692b69` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2971)
[Finished] [`61692b69` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2996)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35878: GH-35838: [C++] Fix asof join backpresure
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35878:
URL: https://github.com/apache/arrow/pull/35878#issuecomment-1574599615
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/01701b4a2331457b966152cab9b4de59...6646aacbc3714a1a8be7d1730f4009a8/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org