You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ab...@apache.org on 2017/07/07 13:42:55 UTC

[14/32] lucene-solr:jira/solr-10996: SOLR-10396: Tweak log messages

SOLR-10396: Tweak log messages


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/b452b3c4
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/b452b3c4
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/b452b3c4

Branch: refs/heads/jira/solr-10996
Commit: b452b3c45142b51b377f47b887c0c15b19120e20
Parents: 17d8417
Author: Shalin Shekhar Mangar <sh...@apache.org>
Authored: Wed Jul 5 10:03:34 2017 +0530
Committer: Shalin Shekhar Mangar <sh...@apache.org>
Committed: Thu Jul 6 09:06:23 2017 +0530

----------------------------------------------------------------------
 .../org/apache/solr/cloud/autoscaling/NodeLostTrigger.java    | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/b452b3c4/solr/core/src/java/org/apache/solr/cloud/autoscaling/NodeLostTrigger.java
----------------------------------------------------------------------
diff --git a/solr/core/src/java/org/apache/solr/cloud/autoscaling/NodeLostTrigger.java b/solr/core/src/java/org/apache/solr/cloud/autoscaling/NodeLostTrigger.java
index 9db388d..bd9b745 100644
--- a/solr/core/src/java/org/apache/solr/cloud/autoscaling/NodeLostTrigger.java
+++ b/solr/core/src/java/org/apache/solr/cloud/autoscaling/NodeLostTrigger.java
@@ -224,11 +224,10 @@ public class NodeLostTrigger extends TriggerBase {
           throw new RuntimeException("Trigger has been closed");
         }
       }
-      log.debug("Running NodeLostTrigger: {}", name);
 
       ZkStateReader reader = container.getZkController().getZkStateReader();
       Set<String> newLiveNodes = reader.getClusterState().getLiveNodes();
-      log.debug("Found livenodes: {}", newLiveNodes);
+      log.debug("Running NodeLostTrigger: {} with currently live nodes: {}", name, newLiveNodes);
 
       // have any nodes that we were tracking been added to the cluster?
       // if so, remove them from the tracking map
@@ -252,10 +251,12 @@ public class NodeLostTrigger extends TriggerBase {
           // fire!
           AutoScaling.TriggerListener listener = listenerRef.get();
           if (listener != null) {
-            log.debug("NodeLostTrigger firing registered listener");
+            log.debug("NodeLostTrigger firing registered listener for lost node: {}", nodeName);
             if (listener.triggerFired(new NodeLostEvent(getEventType(), getName(), timeRemoved, nodeName)))  {
               it.remove();
               removeNodeLostMarker(nodeName);
+            } else  {
+              log.debug("NodeLostTrigger listener for lost node: {} is not ready, will try later", nodeName);
             }
           } else  {
             it.remove();