You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/29 09:16:12 UTC

[GitHub] [arrow-rs] HaoYang670 commented on pull request #1963: Fix Dictionary null_count

HaoYang670 commented on PR #1963:
URL: https://github.com/apache/arrow-rs/pull/1963#issuecomment-1169734063

   > Hmm, there are some integration test failures. It makes me rethink if I misunderstand the API. Marked this is draft. If it doesn't make sense, I will close this later.
   
   I find this in the Arrow Format page: https://arrow.apache.org/docs/format/Columnar.html#dictionary-encoded-layout
   ```
   The null count of such arrays is dictated only by the validity bitmap of its indices, irrespective of any null values in the dictionary.
   ```
   
   It means that if a value is null, we should return `Some(None)` but not `None`. Not 100% sure about this.🤔


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org