You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "FrankYang0529 (via GitHub)" <gi...@apache.org> on 2023/06/22 14:55:08 UTC

[GitHub] [yunikorn-k8shim] FrankYang0529 opened a new pull request, #622: [YUNIKORN-1820] update yunikorn-scheduler-interface & yunikorn-core

FrankYang0529 opened a new pull request, #622:
URL: https://github.com/apache/yunikorn-k8shim/pull/622

   ### What is this PR for?
   
   Update yunikorn-scheduler-interface & yunikorn-core to include grpc 1.56.0.
   
   Note: I updated some functions to return pointers in `pkg/common/si_helper.go`, because `go vet` return some errors like:
   
   ```
   pkg/common/si_helper.go:98:9: return copies lock value: github.com/apache/yunikorn-scheduler-interface/lib/go/si.AllocationRequest contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex
   ```
   
   
   ### What type of PR is it?
   * [ ] - Bug Fix
   * [X] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   
   https://issues.apache.org/jira/browse/YUNIKORN-1820
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yunikorn-k8shim] pbacsko commented on pull request #622: [YUNIKORN-1820] update yunikorn-scheduler-interface & yunikorn-core

Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko commented on PR #622:
URL: https://github.com/apache/yunikorn-k8shim/pull/622#issuecomment-1603194839

   > Note: I updated some functions to return pointers in `pkg/common/si_helper.go`, because `go vet` return some errors like:
   > 
   > ```
   > pkg/common/si_helper.go:98:9: return copies lock value: github.com/apache/yunikorn-scheduler-interface/lib/go/si.AllocationRequest contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex
   > ```
   
   That's good, mutexes are not supposed to be value-copied (just like atomic variables). 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yunikorn-k8shim] wilfred-s closed pull request #622: [YUNIKORN-1820] update yunikorn-scheduler-interface & yunikorn-core

Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #622: [YUNIKORN-1820] update yunikorn-scheduler-interface & yunikorn-core
URL: https://github.com/apache/yunikorn-k8shim/pull/622


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org