You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/14 19:10:37 UTC

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #16607: [fix] PulsarLedgerManager: add missed return statement

michaeljmarshall opened a new pull request, #16607:
URL: https://github.com/apache/pulsar/pull/16607

   ### Motivation
   
   I observed the following error log in the bookkeeper:
   
   > 2022-07-13T23:42:21,390+0000 [main-EventThread] ERROR org.apache.pulsar.metadata.bookkeeper.PulsarLedgerManager - Could not read metadata for ledger: 154498: java.util.NoSuchElementException: No value present
   
   In looking closer, the error happens because there is a missing return statement after completing a promise.
   
   The bug is cosmetic because the promise is completed with the correct error.
   
   ### Modifications
   
   * Add a return statement after completing the promise.
   
   ### Verifying this change
   
   No tests are needed since the effect of this bug is only a confusing log line.
   
   ### Does this pull request potentially affect one of the following parts:
   
   This is not a breaking change.
   
   ### Documentation
   
   - [x] `doc-not-needed` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat commented on pull request #16607: [fix] PulsarLedgerManager: add missed return statement

Posted by GitBox <gi...@apache.org>.
merlimat commented on PR #16607:
URL: https://github.com/apache/pulsar/pull/16607#issuecomment-1184869510

   This should only be relevant for backporting to 2.10 branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #16607: [fix] PulsarLedgerManager: add missed return statement

Posted by GitBox <gi...@apache.org>.
merlimat merged PR #16607:
URL: https://github.com/apache/pulsar/pull/16607


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #16607: [fix] PulsarLedgerManager: add missed return statement

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #16607:
URL: https://github.com/apache/pulsar/pull/16607#issuecomment-1184896928

   @merlimat - makes sense, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org