You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/07/04 13:40:18 UTC
[GitHub] flink pull request #4253: [FLINK-7097] [scripts] Enable Flip-6 TaskExecutor ...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4253
[FLINK-7097] [scripts] Enable Flip-6 TaskExecutor to be started with taskmanager.sh
This PR Is based on #4252.
The taskmanager.sh script now supports to start a TaskExecutor by providing flip6 as
a second argument to the script.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink taskExecutorScripts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4253.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4253
----
commit dbd9a5d8fa3d6f3b20ba48484b9098a7fe280403
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-07-04T13:01:18Z
[FLINK-7074] [tm] Add entry point for the TaskManagerRunner
The entry point can be used by the standalone mode to run a TaskManager. Moreover, the
YarnTaskExecutorRunner now reuses some of the start up logic of the TaskManagerRunner.
commit ad4e21ed401c1409db7b4037ac984fe16aafe435
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-07-04T13:37:15Z
[FLINK-7097] [scripts] Enable Flip-6 TaskExecutor to be started with taskmanager.sh
The taskmanager.sh script now supports to start a TaskExecutor by providing flip6 as
a second argument to the script.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4253: [FLINK-7097] [scripts] Enable Flip-6 TaskExecutor ...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4253#discussion_r125476796
--- Diff: flink-dist/src/main/flink-bin/bin/taskmanager.sh ---
@@ -73,11 +78,11 @@ if [[ $STARTSTOP == "start" ]] || [[ $STARTSTOP == "start-foreground" ]]; then
fi
if [[ $STARTSTOP == "start-foreground" ]]; then
- exec "${FLINK_BIN_DIR}"/flink-console.sh taskmanager "${args[@]}"
+ exec "${FLINK_BIN_DIR}"/flink-console.sh TYPE "${args[@]}"
--- End diff --
should this be $TYPE?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4253: [FLINK-7097] [scripts] Enable Flip-6 TaskExecutor ...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4253#discussion_r125477115
--- Diff: flink-runtime/pom.xml ---
@@ -117,6 +117,16 @@ under the License.
</dependency>
<dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>log4j</groupId>
--- End diff --
IIRC we explicitly removed these dependencies so that other logging frameworks can be plugged in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4253: [FLINK-7097] [scripts] Enable Flip-6 TaskExecutor to be s...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4253
Thanks for your review @zentol. Merging this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4253: [FLINK-7097] [scripts] Enable Flip-6 TaskExecutor ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4253
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4253: [FLINK-7097] [scripts] Enable Flip-6 TaskExecutor ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4253#discussion_r125502076
--- Diff: flink-dist/src/main/flink-bin/bin/taskmanager.sh ---
@@ -73,11 +78,11 @@ if [[ $STARTSTOP == "start" ]] || [[ $STARTSTOP == "start-foreground" ]]; then
fi
if [[ $STARTSTOP == "start-foreground" ]]; then
- exec "${FLINK_BIN_DIR}"/flink-console.sh taskmanager "${args[@]}"
+ exec "${FLINK_BIN_DIR}"/flink-console.sh TYPE "${args[@]}"
--- End diff --
Yup, thanks for catching it :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---