You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ch...@apache.org on 2017/07/26 10:16:09 UTC
[3/5] flink git commit: [FLINK-7254] [java8] Properly activate
checkstyle for flink-java8
[FLINK-7254] [java8] Properly activate checkstyle for flink-java8
This closes #4393.
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/0a7a83f8
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/0a7a83f8
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/0a7a83f8
Branch: refs/heads/master
Commit: 0a7a83f8b01caba7978ade123204906877972834
Parents: d0c3524
Author: zentol <ch...@apache.org>
Authored: Mon Jul 24 14:14:19 2017 +0200
Committer: zentol <ch...@apache.org>
Committed: Wed Jul 26 10:50:42 2017 +0200
----------------------------------------------------------------------
flink-java8/pom.xml | 4 ----
.../flink/api/java/type/lambdas/LambdaExtractionTest.java | 10 +++++-----
.../src/test/java/org/apache/flink/cep/CEPLambdaTest.java | 1 -
flink-java8/src/test/resources/log4j-test.properties | 2 +-
4 files changed, 6 insertions(+), 11 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/0a7a83f8/flink-java8/pom.xml
----------------------------------------------------------------------
diff --git a/flink-java8/pom.xml b/flink-java8/pom.xml
index fb7da02..a3fcea5 100644
--- a/flink-java8/pom.xml
+++ b/flink-java8/pom.xml
@@ -35,10 +35,6 @@ under the License.
<packaging>jar</packaging>
- <properties>
- <checkstyle.skip>true</checkstyle.skip>
- </properties>
-
<dependencies>
<!-- core dependencies -->
http://git-wip-us.apache.org/repos/asf/flink/blob/0a7a83f8/flink-java8/src/test/java/org/apache/flink/api/java/type/lambdas/LambdaExtractionTest.java
----------------------------------------------------------------------
diff --git a/flink-java8/src/test/java/org/apache/flink/api/java/type/lambdas/LambdaExtractionTest.java b/flink-java8/src/test/java/org/apache/flink/api/java/type/lambdas/LambdaExtractionTest.java
index 175c6fe..d862f47 100644
--- a/flink-java8/src/test/java/org/apache/flink/api/java/type/lambdas/LambdaExtractionTest.java
+++ b/flink-java8/src/test/java/org/apache/flink/api/java/type/lambdas/LambdaExtractionTest.java
@@ -327,7 +327,7 @@ public class LambdaExtractionTest {
Assert.assertEquals(BasicTypeInfo.INT_TYPE_INFO, ti);
}
- public interface InterfaceWithDefaultMethod {
+ private interface InterfaceWithDefaultMethod {
void samMethod();
default void defaultMethod() {
@@ -342,7 +342,7 @@ public class LambdaExtractionTest {
assertEquals("samMethod", sam.getName());
}
- public interface InterfaceWithMultipleMethods {
+ private interface InterfaceWithMultipleMethods {
void firstMethod();
void secondMethod();
@@ -353,10 +353,10 @@ public class LambdaExtractionTest {
TypeExtractionUtils.getSingleAbstractMethod(InterfaceWithMultipleMethods.class);
}
- public interface InterfaceWithoutAbstractMethod {
+ private interface InterfaceWithoutAbstractMethod {
default void defaultMethod() {
- };
+ }
}
@Test(expected = InvalidTypesException.class)
@@ -364,7 +364,7 @@ public class LambdaExtractionTest {
TypeExtractionUtils.getSingleAbstractMethod(InterfaceWithoutAbstractMethod.class);
}
- public abstract class AbstractClassWithSingleAbstractMethod {
+ private abstract class AbstractClassWithSingleAbstractMethod {
public abstract void defaultMethod();
}
http://git-wip-us.apache.org/repos/asf/flink/blob/0a7a83f8/flink-java8/src/test/java/org/apache/flink/cep/CEPLambdaTest.java
----------------------------------------------------------------------
diff --git a/flink-java8/src/test/java/org/apache/flink/cep/CEPLambdaTest.java b/flink-java8/src/test/java/org/apache/flink/cep/CEPLambdaTest.java
index 37bf872..7cbdf6a 100644
--- a/flink-java8/src/test/java/org/apache/flink/cep/CEPLambdaTest.java
+++ b/flink-java8/src/test/java/org/apache/flink/cep/CEPLambdaTest.java
@@ -27,7 +27,6 @@ import org.apache.flink.streaming.api.transformations.SourceTransformation;
import org.apache.flink.util.Collector;
import org.apache.flink.util.TestLogger;
-import org.junit.Ignore;
import org.junit.Test;
import java.util.List;
http://git-wip-us.apache.org/repos/asf/flink/blob/0a7a83f8/flink-java8/src/test/resources/log4j-test.properties
----------------------------------------------------------------------
diff --git a/flink-java8/src/test/resources/log4j-test.properties b/flink-java8/src/test/resources/log4j-test.properties
index 2fb9345..c977d4c 100644
--- a/flink-java8/src/test/resources/log4j-test.properties
+++ b/flink-java8/src/test/resources/log4j-test.properties
@@ -16,4 +16,4 @@
# limitations under the License.
################################################################################
-log4j.rootLogger=OFF
\ No newline at end of file
+log4j.rootLogger=OFF