You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/28 13:08:16 UTC

[GitHub] [pulsar] andrasbeni opened a new pull request, #17826: [fix][cli] Check numMessages after incrementing counter

andrasbeni opened a new pull request, #17826:
URL: https://github.com/apache/pulsar/pull/17826

   Fixes #17823
   
   ### Motivation
   
   If PerformanceReader can read exactly as many messages as specified by `num-messages`, it does not stop but waits for another message.
   
   ### Modifications
   
   Check the number of total messages after incrementing the counter.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   
   This change added tests and can be verified as follows:
     - Added integration tests for `pulsar-perf read` 
    
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [x] `doc-not-needed` 
   This is a bugfix
   
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   
   ### Matching PR in forked repository
   
   PR in forked repository: https://github.com/andrasbeni/pulsar/pull/6
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #17826: [fix][cli] Check numMessages after incrementing counter

Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #17826:
URL: https://github.com/apache/pulsar/pull/17826


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui closed pull request #17826: [fix][cli] Check numMessages after incrementing counter

Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #17826: [fix][cli] Check numMessages after incrementing counter 
URL: https://github.com/apache/pulsar/pull/17826


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] andrasbeni commented on pull request #17826: [fix][cli] Check numMessages after incrementing counter

Posted by GitBox <gi...@apache.org>.
andrasbeni commented on PR #17826:
URL: https://github.com/apache/pulsar/pull/17826#issuecomment-1261905816

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org