You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/04/03 06:34:04 UTC
[GitHub] [incubator-dolphinscheduler] KEN-LJQ opened a new issue #2368:
[BUG] multiple browser tab cause cron scheduler trigger duplicate
KEN-LJQ opened a new issue #2368: [BUG] multiple browser tab cause cron scheduler trigger duplicate
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2368
**Describe the bug**
We found some workflow will schedule two instance at the same time every day. Because it has set two Quartz Trigger, see the screenshots below
Since we can see that the difference is trigger group, the suffix means project id, so it indicate this workflow belong to difference project, which suppose to be wrong.
After review the code, the project id comes from the set-scheduler-online-or-offline request, the value is pass by frontend
**To Reproduce**
key operations: open two or more tabs, offline and online scheduler
Assume we have to project: project-1, project-2, and workflow-A belong to project-1
1. Open the cron scheduler page of workflow-A
2. New a tab, and open another workflow of project-2
3. Refresh the cron scheduler page of workflow-A
4. Offline scheduler of workflow-A
5. Online scheduler of workflow-A
After these step, the old cron trigger did not remove, but a new one was added, and the trigger group was difference
**Which version of Dolphin Scheduler:**
-[1.1.0]
**Additional context**
Using DolphinScheduler within only one tab can avoid this bug, but it's more convenience for developer if them open one more tab, so this bug may be trigger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #2368:
[BUG] multiple browser tab cause cron scheduler trigger duplicate
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #2368: [BUG] multiple browser tab cause cron scheduler trigger duplicate
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2368#issuecomment-611434816
@break60 , this is front-end problem, please fix , 1.2.0 also exists this problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #2368:
[BUG] multiple browser tab cause cron scheduler trigger duplicate
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #2368: [BUG] multiple browser tab cause cron scheduler trigger duplicate
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2368#issuecomment-608268079
good job
and do you have good idea to solve this problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] break60 commented on issue #2368:
[BUG] multiple browser tab cause cron scheduler trigger duplicate
Posted by GitBox <gi...@apache.org>.
break60 commented on issue #2368: [BUG] multiple browser tab cause cron scheduler trigger duplicate
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2368#issuecomment-611442232
Your problem has been fixed in 1.2.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #2368:
[BUG] multiple browser tab cause cron scheduler trigger duplicate
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #2368: [BUG] multiple browser tab cause cron scheduler trigger duplicate
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2368#issuecomment-611450878
I just learned that this also has been fixed in the dev branch, next version will also solved this problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong closed issue #2368: [BUG]
multiple browser tab cause cron scheduler trigger duplicate
Posted by GitBox <gi...@apache.org>.
dailidong closed issue #2368: [BUG] multiple browser tab cause cron scheduler trigger duplicate
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] KEN-LJQ commented on issue #2368:
[BUG] multiple browser tab cause cron scheduler trigger duplicate
Posted by GitBox <gi...@apache.org>.
KEN-LJQ commented on issue #2368: [BUG] multiple browser tab cause cron scheduler trigger duplicate
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2368#issuecomment-610122383
Instead of get the project name from frontend request, an option is get the `process_definition_id` from `t_ds_schedules` table record, and then query table `t_ds_process_definition` to get the project id, finally we can get the project infomation from `t_ds_projects`.
But compare with the original implement, the cost is we have to do one more db query.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services