You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/03/19 05:31:46 UTC

[GitHub] [hbase] saintstack commented on a change in pull request #1301: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal

saintstack commented on a change in pull request #1301: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal	
URL: https://github.com/apache/hbase/pull/1301#discussion_r394794024
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java
 ##########
 @@ -355,6 +353,55 @@ private void sendSaslMessage(ChannelHandlerContext ctx, byte[] payload) throws I
       return Collections.singletonList(new CipherOption(CipherSuite.AES_CTR_NOPADDING));
     }
 
+    private static class BuilderPayloadSetter {
 
 Review comment:
   Smile. These gymastics need big comment here to explain magic going on here. Smile.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services