You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/28 07:26:44 UTC

[GitHub] [flink] zoudaokoulife opened a new pull request #10712: [FLINK-15389][Connectors/flink-jdbc] JDBCUpsertOutputFormat no need to create schedule flush when flushMaxSize = 1

zoudaokoulife opened a new pull request #10712: [FLINK-15389][Connectors/flink-jdbc] JDBCUpsertOutputFormat no need to create schedule flush when flushMaxSize = 1
URL: https://github.com/apache/flink/pull/10712
 
 
   
   ## What is the purpose of the change
   JDBCUpsertOutputFormat no need to create schedule flush when flushMaxSize = 1
   
   ## Brief change log
   modify create create flush scheduler condition
   `if (flushIntervalMills != 0)`  
   to
   `if (flushIntervalMills != 0 && flushMaxSize != 1)`
   
   ## Verifying this change
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: ( no )
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no )
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not applicable )
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong closed pull request #10712: [FLINK-15389][Connectors/flink-jdbc] JDBCUpsertOutputFormat no need to create schedule flush when flushMaxSize = 1

Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #10712: [FLINK-15389][Connectors/flink-jdbc] JDBCUpsertOutputFormat no need to create schedule flush when flushMaxSize = 1
URL: https://github.com/apache/flink/pull/10712
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10712: [FLINK-15389][Connectors/flink-jdbc] JDBCUpsertOutputFormat no need to create schedule flush when flushMaxSize = 1

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10712: [FLINK-15389][Connectors/flink-jdbc] JDBCUpsertOutputFormat no need to create schedule flush when flushMaxSize = 1
URL: https://github.com/apache/flink/pull/10712#issuecomment-569396800
 
 
   <!--
   Meta data
   Hash:1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa
   -->
   ## CI report:
   
   * 1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10712: [FLINK-15389][Connectors/flink-jdbc] JDBCUpsertOutputFormat no need to create schedule flush when flushMaxSize = 1

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10712: [FLINK-15389][Connectors/flink-jdbc] JDBCUpsertOutputFormat no need to create schedule flush when flushMaxSize = 1
URL: https://github.com/apache/flink/pull/10712#issuecomment-569396800
 
 
   <!--
   Meta data
   Hash:1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3965 TriggerType:PUSH TriggerID:1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa
   Hash:1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142515249 TriggerType:PUSH TriggerID:1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa
   -->
   ## CI report:
   
   * 1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142515249) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3965) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10712: [FLINK-15389][Connectors/flink-jdbc] JDBCUpsertOutputFormat no need to create schedule flush when flushMaxSize = 1

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10712: [FLINK-15389][Connectors/flink-jdbc] JDBCUpsertOutputFormat no need to create schedule flush when flushMaxSize = 1
URL: https://github.com/apache/flink/pull/10712#issuecomment-569396800
 
 
   <!--
   Meta data
   Hash:1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3965 TriggerType:PUSH TriggerID:1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa
   Hash:1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142515249 TriggerType:PUSH TriggerID:1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa
   -->
   ## CI report:
   
   * 1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142515249) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3965) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10712: [FLINK-15389][Connectors/flink-jdbc] JDBCUpsertOutputFormat no need to create schedule flush when flushMaxSize = 1

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10712: [FLINK-15389][Connectors/flink-jdbc] JDBCUpsertOutputFormat no need to create schedule flush when flushMaxSize = 1
URL: https://github.com/apache/flink/pull/10712#issuecomment-569396800
 
 
   <!--
   Meta data
   Hash:1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3965 TriggerType:PUSH TriggerID:1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa
   Hash:1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142515249 TriggerType:PUSH TriggerID:1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa
   -->
   ## CI report:
   
   * 1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142515249) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3965) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10712: [FLINK-15389][Connectors/flink-jdbc] JDBCUpsertOutputFormat no need to create schedule flush when flushMaxSize = 1

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10712: [FLINK-15389][Connectors/flink-jdbc] JDBCUpsertOutputFormat no need to create schedule flush when flushMaxSize = 1
URL: https://github.com/apache/flink/pull/10712#issuecomment-569394891
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 1ff4b6620fb5a9c9c9dcdf0131a9d448999ed9fa (Sat Dec 28 07:29:37 UTC 2019)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services