[jira] [Commented] (SSHD-347) Sftplet.onConnect(...) does not obtain access to ServerSession

["Emmanuel Lecharny (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SSHD-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14125251#comment-14125251 ] 

Emmanuel Lecharny commented on SSHD-347:
----------------------------------------

Moved to SSHD. This is not a MINA error.

> Sftplet.onConnect(...) does not obtain access to ServerSession
> --------------------------------------------------------------
>
>                 Key: SSHD-347
>                 URL: https://issues.apache.org/jira/browse/SSHD-347
>             Project: MINA SSHD
>          Issue Type: Bug
>            Reporter: Dmitri Priimak
>
> Using Sftplet I encountered one small problem. 
> In current git repo in file
> sshd-sftp/src/main/java/org/apache/sshd/sftp/subsyste/SftpSubsystem.java
> in lines 138 through 141 there is following code
> public void setSession(ServerSession session) {
>     sftpLet.onConnect(this);
>     this.session = session;
> }
> This calls sftpLet.onConnect(...) before session is set, which means that at that stage information from the session such as user name of the 
> person who logged in or the remote ip address is not available in inside of onConnect(...) call even though ServerServer already has this information.
> A simple swapping of just two lines should fix that, like so
> public void setSession(ServerSession session) {
>     this.session = session;
>     sftpLet.onConnect(this);
> }
> Can such change be made in your code?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)