You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jdanekrh <gi...@git.apache.org> on 2017/07/18 21:01:12 UTC
[GitHub] activemq-artemis pull request #1409: ARTEMIS-1276 avoid System.exit in tests...
GitHub user jdanekrh opened a pull request:
https://github.com/apache/activemq-artemis/pull/1409
ARTEMIS-1276 avoid System.exit in tests as Surefire cannot deal with that
This change results in many more tests being run. Previously, 662 tests
were executed. Now, 1166 tests is executed. The running time has increased
from ~20 minutes to ~50 minutes.
Before
> Tests run: 662, Failures: 14, Errors: 4, Skipped: 1
After
> Tests run: 1166, Failures: 38, Errors: 1, Skipped: 2
(the second commit in the PR disables one of the erroring tests, because it tests feature that Artemis does not implement)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jdanekrh/activemq-artemis jd_fix_exit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1409.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1409
----
commit 4bf4ec552612f5001897b195d27c61e48efdb00e
Author: Jiri Danek <jd...@redhat.com>
Date: 2017-07-17T09:51:55Z
ARTEMIS-1276 avoid System.exit in tests as Surefire cannot deal with that
This change results in many more tests being run. Previously, 662 tests
were executed. Now, 1166 tests is executed. The running time has increased
from ~20 minutes to ~50 minutes.
commit 3ec9137a4656a5c7b35a469cde34ce2ab86177b8
Author: Jiri Danek <jd...@redhat.com>
Date: 2017-07-18T11:55:07Z
ARTEMIS-1276 disable MessageEvictionTest
The test is broken. It can be fixed by doing
```java
FakeTransportConnector(URI uri) {
setServer(new TransportServer {
@Override
public URI getConnectURI() {
return uri;
}
but then the test would fail because message
eviction is not supported by Artemis.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1409: ARTEMIS-1276 avoid System.exit in tests...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1409#discussion_r128123382
--- Diff: tests/activemq5-unit-tests/pom.xml ---
@@ -460,6 +460,8 @@
<exclude>**/org/apache/activemq/ProducerFlowControlTest.java</exclude>
<!-- exclude tests that are on client side only -->
<exclude>**/org/apache/activemq/transport/tcp/TransportConnectorInvalidSocketOptionsTest.java</exclude>
+ <!-- exclude tests for features not implemented in Artemis -->
+ <exclude>**/org/apache/activemq/MessageEvictionTest.java</exclude>
--- End diff --
why not just remove the test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1409: ARTEMIS-1276 avoid System.exit in tests as Sur...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1409
Just remove the test then please ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1409: ARTEMIS-1276 avoid System.exit in tests...
Posted by jdanekrh <gi...@git.apache.org>.
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1409#discussion_r128155276
--- Diff: tests/activemq5-unit-tests/pom.xml ---
@@ -460,6 +460,8 @@
<exclude>**/org/apache/activemq/ProducerFlowControlTest.java</exclude>
<!-- exclude tests that are on client side only -->
<exclude>**/org/apache/activemq/transport/tcp/TransportConnectorInvalidSocketOptionsTest.java</exclude>
+ <!-- exclude tests for features not implemented in Artemis -->
+ <exclude>**/org/apache/activemq/MessageEvictionTest.java</exclude>
--- End diff --
if that is how it is done regarding non-applicable activemq5 tests in Artemis, then sure, I can just delete the test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1409: ARTEMIS-1276 avoid System.exit in tests...
Posted by jdanekrh <gi...@git.apache.org>.
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1409#discussion_r128231365
--- Diff: tests/activemq5-unit-tests/pom.xml ---
@@ -460,6 +460,8 @@
<exclude>**/org/apache/activemq/ProducerFlowControlTest.java</exclude>
<!-- exclude tests that are on client side only -->
<exclude>**/org/apache/activemq/transport/tcp/TransportConnectorInvalidSocketOptionsTest.java</exclude>
+ <!-- exclude tests for features not implemented in Artemis -->
+ <exclude>**/org/apache/activemq/MessageEvictionTest.java</exclude>
--- End diff --
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1409: ARTEMIS-1276 avoid System.exit in tests...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1409
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---