[GitHub] [incubator-superset] villebro commented on a change in pull request #8732: [config] Enables swagger UI by default

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #8732: [config] Enables swagger UI by default
URL: https://github.com/apache/incubator-superset/pull/8732#discussion_r353328368
 
 

 ##########
 File path: superset/config.py
 ##########
 @@ -162,7 +161,9 @@ def _try_json_readsha(filepath):
 # Uncomment to specify where clicking the logo would take the user
 # e.g. setting it to '/welcome' would take the user to '/superset/welcome'
 LOGO_TARGET_PATH = None
-
+# Enables SWAGGER UI for superset openapi spec
+# ex: http://localhost:8080/swaggerview/v1
+FAB_API_SWAGGER_UI = True
 # Druid query timezone
 # tz.tzutc() : Using utc timezone
 # tz.tzlocal() : Using local timezone
 
 Review comment:
   nit: I kinda like having a blank line highlighting separate sections. Would prefer to leave the old blank line after `LOGO_TARGET_PATH` and also adding a new one after `FAB_API_SWAGGER_UI`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org