You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/09 19:47:46 UTC
[GitHub] [incubator-superset] willbarrett opened a new pull request #9497:
Fix broken MultiLine chart
willbarrett opened a new pull request #9497: Fix broken MultiLine chart
URL: https://github.com/apache/incubator-superset/pull/9497
### CATEGORY
Choose one
- [X] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
The lines altered in this PR were introduced 8 days ago in this commit: https://github.com/apache/incubator-superset/commit/f0f4f7e91df0adc3a76292381f1ef6a8f579af95
These lines broke
the Multi Line visualization, as that visualization has no `from_dttm` or `to_dttm` attributes. MultiLine visualizations on current master display the error `'MultiLineViz object has no attribute 'from_dttm'`.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before:

After:

### TEST PLAN
<!--- What steps should be taken to verify the changes -->
I've manually tested the change locally. You can verify the fix by navigating to:
Dashbaoards -> Misc Charts
and scrolling to the bottom where the "Multi Line" chart is displayed.
I'm going to look into adding a unit test for this next.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@villebro @dpgaspar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #9497: Fix broken
MultiLine chart
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #9497: Fix broken MultiLine chart
URL: https://github.com/apache/incubator-superset/pull/9497#issuecomment-612147375
It seems once GH drops Travis like this, there's no coming back. It's not elegant I know, but I propose closing this and opening a new PR, as this is a pretty critical fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #9497: Fix
broken MultiLine chart
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #9497: Fix broken MultiLine chart
URL: https://github.com/apache/incubator-superset/pull/9497#issuecomment-612144068
OK, build passed again, still no status update from Travis. Does anyone have admin access to merge in this type of situation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #9497: Fix broken
MultiLine chart
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #9497: Fix broken MultiLine chart
URL: https://github.com/apache/incubator-superset/pull/9497#issuecomment-612116936
Travis is currently almost doing more harm than good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #9497: Fix
broken MultiLine chart
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #9497: Fix broken MultiLine chart
URL: https://github.com/apache/incubator-superset/pull/9497#issuecomment-612147770
OK, closing + reopening.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett closed pull request #9497: Fix
broken MultiLine chart
Posted by GitBox <gi...@apache.org>.
willbarrett closed pull request #9497: Fix broken MultiLine chart
URL: https://github.com/apache/incubator-superset/pull/9497
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #9497: Fix
broken MultiLine chart
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #9497: Fix broken MultiLine chart
URL: https://github.com/apache/incubator-superset/pull/9497#issuecomment-612122141
Agreed. We're going to try to support the Github Actions work next week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #9497: Fix
broken MultiLine chart
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #9497: Fix broken MultiLine chart
URL: https://github.com/apache/incubator-superset/pull/9497#issuecomment-612108609
Travis has passed CI but the status wasn't reported to Github :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org