[GitHub] [ozone] bharatviswa504 commented on a change in pull request #1608: HDDS-4481. With HA OM can send deletion blocks to SCM multiple times.

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #1608:
URL: https://github.com/apache/ozone/pull/1608#discussion_r529833960



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java
##########
@@ -126,15 +126,32 @@ private static long nextCallId() {
   public OMResponse submitRequest(OMRequest omRequest) throws ServiceException {
     RaftClientRequest raftClientRequest =
         createWriteRaftClientRequest(omRequest);

Review comment:
       When called from Client, Server.getCallID() will not return constant value RpcConstants.INVALID_RETRY_COUNT.
   Where as when keydeletingService is called it is not coming thru RpcClient, directly calling server API submitRequest, so CallID will be same for each call.
   
   So it is fine use createWriteRaftClientRequest for normal flow of requests, and the values ClientID and CallID can be fetched from Server.getClientID and Server.getCallID().




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org