You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/04/26 05:25:14 UTC

[GitHub] [spark] itholic commented on a diff in pull request #40658: [WIP][SPARK-43024][PS] Upgrade pandas to 2.0.0

itholic commented on code in PR #40658:
URL: https://github.com/apache/spark/pull/40658#discussion_r1177354305


##########
python/pyspark/pandas/tests/test_dataframe_slow.py:
##########
@@ -1949,41 +1926,45 @@ def test_between_time(self):
         idx = pd.date_range("2018-04-09", periods=4, freq="1D20min")
         pdf = pd.DataFrame({"A": [1, 2, 3, 4]}, index=idx)
         psdf = ps.from_pandas(pdf)
-        self.assert_eq(
-            pdf.between_time("0:15", "0:45").sort_index(),
-            psdf.between_time("0:15", "0:45").sort_index(),
-        )
+        # This will be addressed from ongoing PR: https://github.com/apache/spark/pull/40370.

Review Comment:
   cc @dzhigimont FYI.
   I believe your ongoing PRs will be available to merge after this PR is done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org