You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Everett Toews <no...@github.com> on 2013/10/14 17:16:40 UTC
[jclouds] Fixes for BaseOpenStackMockTest and ParseAccessTest (#182)
2 commits for the different fixes.
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds fixes
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/182
-- Commit Summary --
* Renamed variable and method more appropriately.
* Fixed imports and formatting.
-- File Changes --
M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/parse/ParseAccessTest.java (201)
M apis/openstack-keystone/src/test/java/org/jclouds/openstack/v2_0/internal/BaseOpenStackMockTest.java (12)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/182.patch
https://github.com/jclouds/jclouds/pull/182.diff
Re: [jclouds] Fixes for BaseOpenStackMockTest and ParseAccessTest
(#182)
Posted by Andrew Phillips <no...@github.com>.
> @@ -31,7 +28,17 @@
> import org.jclouds.rest.annotations.SelectJson;
> import org.testng.annotations.Test;
>
> -import static org.jclouds.openstack.v2_0.ServiceType.*;
> +import javax.ws.rs.Consumes;
> +import javax.ws.rs.core.MediaType;
> +
> +import static org.jclouds.openstack.v2_0.ServiceType.BLOCK_STORAGE;
> +import static org.jclouds.openstack.v2_0.ServiceType.COMPUTE;
> +import static org.jclouds.openstack.v2_0.ServiceType.DATABASE_SERVICE;
> +import static org.jclouds.openstack.v2_0.ServiceType.IDENTITY;
> +import static org.jclouds.openstack.v2_0.ServiceType.IMAGE;
> +import static org.jclouds.openstack.v2_0.ServiceType.NETWORK;
> +import static org.jclouds.openstack.v2_0.ServiceType.OBJECT_STORE;
> +import static org.jclouds.openstack.v2_0.ServiceType.QUEUES;
Any particular reason for the import change. I guess we don't want to use `*` imports?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/182/files#r6975294
Re: [jclouds] Fixes for BaseOpenStackMockTest and ParseAccessTest
(#182)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #306](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/306/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/182#issuecomment-26286984
Re: [jclouds] Fixes for BaseOpenStackMockTest and ParseAccessTest
(#182)
Posted by Everett Toews <no...@github.com>.
> @@ -31,7 +28,17 @@
> import org.jclouds.rest.annotations.SelectJson;
> import org.testng.annotations.Test;
>
> -import static org.jclouds.openstack.v2_0.ServiceType.*;
> +import javax.ws.rs.Consumes;
> +import javax.ws.rs.core.MediaType;
> +
> +import static org.jclouds.openstack.v2_0.ServiceType.BLOCK_STORAGE;
> +import static org.jclouds.openstack.v2_0.ServiceType.COMPUTE;
> +import static org.jclouds.openstack.v2_0.ServiceType.DATABASE_SERVICE;
> +import static org.jclouds.openstack.v2_0.ServiceType.IDENTITY;
> +import static org.jclouds.openstack.v2_0.ServiceType.IMAGE;
> +import static org.jclouds.openstack.v2_0.ServiceType.NETWORK;
> +import static org.jclouds.openstack.v2_0.ServiceType.OBJECT_STORE;
> +import static org.jclouds.openstack.v2_0.ServiceType.QUEUES;
I think we want to avoid it until we have a code style guideline for it.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/182/files#r6975982
Re: [jclouds] Fixes for BaseOpenStackMockTest and ParseAccessTest
(#182)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #768](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/768/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/182#issuecomment-26286997
Re: [jclouds] Fixes for BaseOpenStackMockTest and ParseAccessTest
(#182)
Posted by Everett Toews <no...@github.com>.
I'd like to get feedback from @demobox and @adriancole on this before merging.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/182#issuecomment-26269887
Re: [jclouds] Fixes for BaseOpenStackMockTest and ParseAccessTest
(#182)
Posted by Everett Toews <no...@github.com>.
@demobox Did you want to talk one final look at this PR?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/182#issuecomment-26345012
Re: [jclouds] Fixes for BaseOpenStackMockTest and ParseAccessTest
(#182)
Posted by Andrew Phillips <no...@github.com>.
+1 - looks good to me!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/182#issuecomment-26347487
Re: [jclouds] Fixes for BaseOpenStackMockTest and ParseAccessTest
(#182)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #766](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/766/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/182#issuecomment-26265215
Re: [jclouds] Fixes for BaseOpenStackMockTest and ParseAccessTest
(#182)
Posted by Andrew Phillips <no...@github.com>.
Thanks, @everett-toews! The commits were intentionally merged individually (rather than squashed), I take it?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/182#issuecomment-26404562
Re: [jclouds] Fixes for BaseOpenStackMockTest and ParseAccessTest
(#182)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #304](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/304/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/182#issuecomment-26265241