You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2018/08/16 23:18:20 UTC
Review Request 68397: Updated the ::pipe() system calls to pipe2 in
lib_logrotate.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68397/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin Mahler, Jie Yu, James Peach, and Qian Zhang.
Bugs: MESOS-9151
https://issues.apache.org/jira/browse/MESOS-9151
Repository: mesos
Description
-------
Updated the ::pipe() system calls to pipe2 in lib_logrotate.
Diffs
-----
src/slave/container_loggers/lib_logrotate.cpp fa71e07290413ae0670f9879cec60f59de005adb
Diff: https://reviews.apache.org/r/68397/diff/1/
Testing
-------
Thanks,
Gilbert Song
Re: Review Request 68397: Updated the ::pipe() system calls to pipe2
in lib_logrotate.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68397/#review207465
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 63280.
Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 63280`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2180/mesos-review-68397
Relevant logs:
- [apply-review-63280.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2180/mesos-review-68397/logs/apply-review-63280.log):
```
error: patch failed: src/slave/containerizer/mesos/containerizer.cpp:1719
error: src/slave/containerizer/mesos/containerizer.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On Aug. 16, 2018, 11:18 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68397/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2018, 11:18 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin Mahler, Jie Yu, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9151
> https://issues.apache.org/jira/browse/MESOS-9151
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the ::pipe() system calls to pipe2 in lib_logrotate.
>
>
> Diffs
> -----
>
> src/slave/container_loggers/lib_logrotate.cpp fa71e07290413ae0670f9879cec60f59de005adb
>
>
> Diff: https://reviews.apache.org/r/68397/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 68397: Updated the ::pipe() system calls to pipe2
in lib_logrotate.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68397/#review207464
-----------------------------------------------------------
Bad patch!
Reviews applied: [68397, 68396, 63682, 63280, 63270]
Failed command: python support/apply-reviews.py -n -r 63280
Error:
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
2018-08-17 01:24:44 URL:https://reviews.apache.org/r/63280/diff/raw/ [1772/1772] -> "63280.patch" [1]
error: patch failed: src/slave/containerizer/mesos/containerizer.cpp:1719
error: src/slave/containerizer/mesos/containerizer.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/23100/console
- Mesos Reviewbot
On Aug. 17, 2018, 7:18 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68397/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 7:18 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin Mahler, Jie Yu, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9151
> https://issues.apache.org/jira/browse/MESOS-9151
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the ::pipe() system calls to pipe2 in lib_logrotate.
>
>
> Diffs
> -----
>
> src/slave/container_loggers/lib_logrotate.cpp fa71e07290413ae0670f9879cec60f59de005adb
>
>
> Diff: https://reviews.apache.org/r/68397/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 68397: Updated the ::pipe() system calls to pipe2
in lib_logrotate.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68397/#review207637
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 63682.
Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 63682`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2199/mesos-review-68397
Relevant logs:
- [apply-review-63682.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2199/mesos-review-68397/logs/apply-review-63682.log):
```
error: patch failed: src/tests/check_tests.cpp:1986
error: src/tests/check_tests.cpp: patch does not apply
error: patch failed: src/tests/containerizer/nested_mesos_containerizer_tests.cpp:455
error: src/tests/containerizer/nested_mesos_containerizer_tests.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On Aug. 20, 2018, 9:38 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68397/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2018, 9:38 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin Mahler, Jie Yu, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9151
> https://issues.apache.org/jira/browse/MESOS-9151
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the ::pipe() system calls to pipe2 in lib_logrotate.
>
>
> Diffs
> -----
>
> src/slave/container_loggers/lib_logrotate.cpp fa71e07290413ae0670f9879cec60f59de005adb
>
>
> Diff: https://reviews.apache.org/r/68397/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 68397: Updated the ::pipe() system calls to pipe2
in lib_logrotate.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68397/#review207638
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 20, 2018, 9:38 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68397/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2018, 9:38 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin Mahler, Jie Yu, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9151
> https://issues.apache.org/jira/browse/MESOS-9151
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the ::pipe() system calls to pipe2 in lib_logrotate.
>
>
> Diffs
> -----
>
> src/slave/container_loggers/lib_logrotate.cpp fa71e07290413ae0670f9879cec60f59de005adb
>
>
> Diff: https://reviews.apache.org/r/68397/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 68397: Updated the ::pipe() system calls to pipe2
in lib_logrotate.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68397/
-----------------------------------------------------------
(Updated Aug. 20, 2018, 2:38 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin Mahler, Jie Yu, James Peach, and Qian Zhang.
Bugs: MESOS-9151
https://issues.apache.org/jira/browse/MESOS-9151
Repository: mesos
Description
-------
Updated the ::pipe() system calls to pipe2 in lib_logrotate.
Diffs (updated)
-----
src/slave/container_loggers/lib_logrotate.cpp fa71e07290413ae0670f9879cec60f59de005adb
Diff: https://reviews.apache.org/r/68397/diff/2/
Changes: https://reviews.apache.org/r/68397/diff/1-2/
Testing
-------
Thanks,
Gilbert Song
Re: Review Request 68397: Updated the ::pipe() system calls to pipe2
in lib_logrotate.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68397/#review207525
-----------------------------------------------------------
src/slave/container_loggers/lib_logrotate.cpp
Line 169 (original), 171 (patched)
<https://reviews.apache.org/r/68397/#comment290928>
You don't need this `cloexec` here any more because `os::pipe()` has already done it.
src/slave/container_loggers/lib_logrotate.cpp
Line 201 (original), 203 (patched)
<https://reviews.apache.org/r/68397/#comment290929>
Here, you need to use the `UNSET_CLOEXEC` child hook to pass the child end of the pipe?
- James Peach
On Aug. 16, 2018, 11:18 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68397/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2018, 11:18 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin Mahler, Jie Yu, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9151
> https://issues.apache.org/jira/browse/MESOS-9151
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the ::pipe() system calls to pipe2 in lib_logrotate.
>
>
> Diffs
> -----
>
> src/slave/container_loggers/lib_logrotate.cpp fa71e07290413ae0670f9879cec60f59de005adb
>
>
> Diff: https://reviews.apache.org/r/68397/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>