You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/12/08 14:42:11 UTC
[GitHub] [cordova-plugin-camera] jcesarmobile commented on a change in pull request #687: fix(android): return exception message (where it exists)
jcesarmobile commented on a change in pull request #687:
URL: https://github.com/apache/cordova-plugin-camera/pull/687#discussion_r538443674
##########
File path: src/android/CameraLauncher.java
##########
@@ -829,7 +829,7 @@ else if (srcType == CAMERA) {
}
} catch (IOException e) {
e.printStackTrace();
- this.failPicture("Error capturing image.");
+ this.failPicture("Error capturing image: "+e.getMessage());
Review comment:
```suggestion
this.failPicture("Error capturing image: "+e.getLocalizedMessage());
```
##########
File path: src/android/CameraLauncher.java
##########
@@ -759,7 +759,7 @@ else if (destType == FILE_URI) {
} catch (Exception e) {
e.printStackTrace();
- this.failPicture("Error retrieving image.");
+ this.failPicture("Error retrieving image: "+e.getMessage());
Review comment:
```suggestion
this.failPicture("Error retrieving image: "+e.getLocalizedMessage());
```
##########
File path: src/android/CameraLauncher.java
##########
@@ -1268,7 +1268,7 @@ public void processPicture(Bitmap bitmap, int encodingType) {
code = null;
}
} catch (Exception e) {
- this.failPicture("Error compressing image.");
+ this.failPicture("Error compressing image: "+e.getMessage());
Review comment:
```suggestion
this.failPicture("Error compressing image: "+e.getLocalizedMessage());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org