You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/10/30 01:44:29 UTC
Review Request 27365: Add FakeStatsProvider and check stat values in
SchedulerLifecycleTest.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27365/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
Bugs: AURORA-884
https://issues.apache.org/jira/browse/AURORA-884
Repository: aurora
Description
-------
Add FakeStatsProvider and check stat values in SchedulerLifecycleTest.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 92ceaed8e4c5baf35c335f015de479ee4c648957
src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 90c8c065adc4329894e99946a8f494ac3e35629b
src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java PRE-CREATION
Diff: https://reviews.apache.org/r/27365/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 27365: Add FakeStatsProvider and check stat values
in SchedulerLifecycleTest.
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27365/#review59092
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Oct. 30, 2014, 12:44 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27365/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2014, 12:44 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
>
>
> Bugs: AURORA-884
> https://issues.apache.org/jira/browse/AURORA-884
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add FakeStatsProvider and check stat values in SchedulerLifecycleTest.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 92ceaed8e4c5baf35c335f015de479ee4c648957
> src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 90c8c065adc4329894e99946a8f494ac3e35629b
> src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27365/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27365: Add FakeStatsProvider and check stat values
in SchedulerLifecycleTest.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27365/#review59095
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Oct. 30, 2014, 12:44 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27365/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2014, 12:44 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
>
>
> Bugs: AURORA-884
> https://issues.apache.org/jira/browse/AURORA-884
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add FakeStatsProvider and check stat values in SchedulerLifecycleTest.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 92ceaed8e4c5baf35c335f015de479ee4c648957
> src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 90c8c065adc4329894e99946a8f494ac3e35629b
> src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27365/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27365: Add FakeStatsProvider and check stat values
in SchedulerLifecycleTest.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27365/#review59100
-----------------------------------------------------------
Ship it!
Master (0f63e8f) is green with this patch.
./build-support/jenkins/build.sh
- Aurora ReviewBot
On Oct. 30, 2014, 12:44 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27365/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2014, 12:44 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
>
>
> Bugs: AURORA-884
> https://issues.apache.org/jira/browse/AURORA-884
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add FakeStatsProvider and check stat values in SchedulerLifecycleTest.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 92ceaed8e4c5baf35c335f015de479ee4c648957
> src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 90c8c065adc4329894e99946a8f494ac3e35629b
> src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27365/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>