You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/09/28 18:02:25 UTC

[GitHub] [hadoop] liuml07 edited a comment on pull request #2321: HADOOP-17267: Add debug-level logs in Filesystem#close

liuml07 edited a comment on pull request #2321:
URL: https://github.com/apache/hadoop/pull/2321#issuecomment-700192324


   >  add the minimum amount of cost possible.
   
   How leaving `if (LOGGER.isDebugEnabled())` out of `debugLogFileSystemClose()` do that? Saving one function call? I do not assume that is a concern. I'm more concerned if people forget to check that when calling the method, so to me putting the check in the function is preferred.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org