Re: [repo] External sources, ICU (was: Who wants to buildOpenOffice?)

[Pedro Giffuni <gi...@tutopia.com>]

 On Fri, 9 Sep 2011 12:11:16 +0200, Eike Rathke <oo...@erack.de> wrote:
> Hi Mathias,
>
> On Thursday, 2011-09-08 19:42:25 +0200, Mathias Bauer wrote:
>
>> > ICU 4.0.1 we use also has regex. Sure, newest ICU probably 
>> improved
>> > there, but upgrading ICU in the past gave some surprises, 
>> especially
>> > regarding break iterators, that made it necessary to adapt some 
>> things.
>> > That should be avoided.
>>
>> Which version of ICU is used in LibreOffice? If they use a newer 
>> one,
>> this probably can tell us about possible "surprises".
>
> The internal ICU is 4.4.2, whether anything needed to be adapted I 
> don't
> know.
>
 From a quick lookup (git really sucks for this type of queries),
 it looks like LO found some bugs in ICU (fixed upstream).

 There was also a bug with Arab glyphs but it was not specific
 to the icu version.

 In sum, I agree we should just wait a bit more.

 I think possible security concerns on other ext. sources (nss, 
 seamonkey,
 probably something else) should be looked into though.

 Cheers,

 Pedro.

Re: [repo] External sources, ICU (was: Who wants to build OpenOffice?)

["Pedro F. Giffuni" <gi...@tutopia.com>]

Hi Eike;

--- On Fri, 9/9/11, Eike Rathke wrote:

> > 
> > There was also a bug with Arab glyphs but it was not
> specific
> > to the icu version.
> 
> Well, yes, for those exist patches in the icu module's
> directory, that's the easy case. What I was referring
> are changes in other modules because of an upgrade of
> ICU, e.g. mostly in i18npool, vcl and sw.
>

The fix for Arab glyphs was in vcl, I couldn't find other
changes. Unfortunately the web interfaces to GIT simply
suck and it's very difficult to find changes like that.

I also have to be careful of avoiding GPL contamination
when looking for changes :(.

Hmm... there is Bug 115897 and you own Bug 104310 but
neither of them has patches.

cheers,

Pedro.

Re: [repo] External sources, ICU (was: Who wants to build OpenOffice?)

[Eike Rathke <oo...@erack.de>]

Hi Pedro,

On Friday, 2011-09-09 07:42:37 -0500, Pedro Giffuni wrote:

> >>Which version of ICU is used in LibreOffice? If they use a newer
> >>one,
> >>this probably can tell us about possible "surprises".
> >
> >The internal ICU is 4.4.2, whether anything needed to be adapted I
> >don't
> >know.
> >
> From a quick lookup (git really sucks for this type of queries),
> it looks like LO found some bugs in ICU (fixed upstream).
> 
> There was also a bug with Arab glyphs but it was not specific
> to the icu version.

Well, yes, for those exist patches in the icu module's directory, that's
the easy case. What I was referring are changes in other modules because
of an upgrade of ICU, e.g. mostly in i18npool, vcl and sw.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD