[GitHub] [pulsar] lhotari commented on a diff in pull request #17858: [ci] Verify checkstyle and spotbugs for all modules

[GitBox <gi...@apache.org>]

lhotari commented on code in PR #17858:
URL: https://github.com/apache/pulsar/pull/17858#discussion_r981322456


##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -104,12 +104,12 @@ jobs:
           distribution: 'temurin'
           java-version: 17
 
-      - name: Check source code license headers
-        run: mvn -B -T 8 -ntp initialize apache-rat:check license:check
+      - name: Check source code license headers, style and spotbugs
+        run: mvn -B -T 8 -ntp initialize apache-rat:check license:check checkstyle:check spotbugs:check
 
       - name: Build core-modules
         run: |
-          mvn -B -T 1C -ntp -Pcore-modules,-main clean install -DskipTests -Dlicense.skip=true -Drat.skip=true
+          mvn -B -T 1C -ntp -Pcore-modules,-main clean install -DskipTests -Dlicense.skip=true -Drat.skip=true -Dcheckstyle.skip -Dspotbugs.skip

Review Comment:
   the syntax for skipping doesn't look right. I'd assume `-Dspotbugs.skip=true`. Please validate locally that the commands do what is expected. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org