You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dajac (via GitHub)" <gi...@apache.org> on 2026/05/05 19:14:56 UTC
[PR] KAFKA-20444: [2/N] Update OffsetMetadataManager to use new TxnOffsetCommit errors (KIP-1319) [kafka]
dajac opened a new pull request, #22214:
URL: https://github.com/apache/kafka/pull/22214
This patch updates `OffsetMetadataManager` to propagate `GROUP_ID_NOT_FOUND` and `STALE_MEMBER_EPOCH` directly starting from version 6 of the `TxnOffsetCommit` API, both at the group lookup and at the per-partition validator. The legacy mapping to `ILLEGAL_GENERATION` is preserved for versions 0 to 5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20444: [2/N] Update OffsetMetadataManager to use new TxnOffsetCommit errors (KIP-1319) [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac merged PR #22214:
URL: https://github.com/apache/kafka/pull/22214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20444: [2/N] Update OffsetMetadataManager to use new TxnOffsetCommit errors (KIP-1319) [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #22214:
URL: https://github.com/apache/kafka/pull/22214#discussion_r3192220235
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -528,7 +529,11 @@ private CommitPartitionValidator validateTransactionalOffsetCommit(
// facility. In this case, a so-called simple group is created and the request
// is accepted.
group = groupMetadataManager.getOrMaybeCreateClassicGroup(request.groupId(), true);
+ } else if (TxnOffsetCommitRequest.supportsGroupIdNotFoundError((short) context.requestVersion())) {
Review Comment:
Not sure why `requestVersion` uses `int` rather than `short`, as `header.apiVersion()` actually returns a short
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20444: [2/N] Update OffsetMetadataManager to use new TxnOffsetCommit errors (KIP-1319) [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #22214:
URL: https://github.com/apache/kafka/pull/22214#discussion_r3193633529
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -528,7 +529,11 @@ private CommitPartitionValidator validateTransactionalOffsetCommit(
// facility. In this case, a so-called simple group is created and the request
// is accepted.
group = groupMetadataManager.getOrMaybeCreateClassicGroup(request.groupId(), true);
+ } else if (TxnOffsetCommitRequest.supportsGroupIdNotFoundError((short) context.requestVersion())) {
Review Comment:
Yeah, not sure why we used an int in AuthorizableRequestContext. It seems to be a mistake to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org