You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Jake Maes <ja...@gmail.com> on 2016/08/12 19:35:36 UTC
Review Request 51047: SAMZA-1000 Fix hello-samza documentation to not
use latest branch by default
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51047/
-----------------------------------------------------------
Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
Bugs: SAMZA-1000
https://issues.apache.org/jira/browse/SAMZA-1000
Repository: samza
Description
-------
SAMZA-1000 Fix hello-samza documentation to not use latest branch by default
Diffs
-----
docs/startup/hello-samza/versioned/index.md 8baacd390d41c5c87a426d63eec9ce5028de0cc2
Diff: https://reviews.apache.org/r/51047/diff/
Testing
-------
Thanks,
Jake Maes
Re: Review Request 51047: SAMZA-1000 Fix hello-samza documentation to
not use latest branch by default
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51047/#review146424
-----------------------------------------------------------
Just noticed that we need to fix one more in the documentation.
docs/startup/hello-samza/versioned/index.md (line 55)
<https://reviews.apache.org/r/51047/#comment212855>
If this tutorial is focusing on released version of Samza, shouldn't this be changed to 0.10.1?
- Yi Pan (Data Infrastructure)
On Aug. 19, 2016, 12:27 a.m., Jake Maes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51047/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2016, 12:27 a.m.)
>
>
> Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-1000
> https://issues.apache.org/jira/browse/SAMZA-1000
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-1000 Fix hello-samza documentation to not use latest branch by default
>
>
> Diffs
> -----
>
> docs/startup/hello-samza/versioned/index.md 8baacd390d41c5c87a426d63eec9ce5028de0cc2
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
>
> Diff: https://reviews.apache.org/r/51047/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jake Maes
>
>
Re: Review Request 51047: SAMZA-1000 Fix hello-samza documentation to
not use latest branch by default
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51047/#review146396
-----------------------------------------------------------
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On Aug. 19, 2016, 12:27 a.m., Jake Maes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51047/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2016, 12:27 a.m.)
>
>
> Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-1000
> https://issues.apache.org/jira/browse/SAMZA-1000
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-1000 Fix hello-samza documentation to not use latest branch by default
>
>
> Diffs
> -----
>
> docs/startup/hello-samza/versioned/index.md 8baacd390d41c5c87a426d63eec9ce5028de0cc2
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
>
> Diff: https://reviews.apache.org/r/51047/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jake Maes
>
>
Re: Review Request 51047: SAMZA-1000 Fix hello-samza documentation to
not use latest branch by default
Posted by Jake Maes <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51047/
-----------------------------------------------------------
(Updated Aug. 19, 2016, 12:27 a.m.)
Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
Bugs: SAMZA-1000
https://issues.apache.org/jira/browse/SAMZA-1000
Repository: samza
Description
-------
SAMZA-1000 Fix hello-samza documentation to not use latest branch by default
Diffs (updated)
-----
docs/startup/hello-samza/versioned/index.md 8baacd390d41c5c87a426d63eec9ce5028de0cc2
gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
Diff: https://reviews.apache.org/r/51047/diff/
Testing
-------
Thanks,
Jake Maes
Re: Review Request 51047: SAMZA-1000 Fix hello-samza documentation to
not use latest branch by default
Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51047/#review146152
-----------------------------------------------------------
gradle.properties (line 18)
<https://reviews.apache.org/r/51047/#comment212534>
It should be 0.11.0-SNAPSHOT
- Navina Ramesh
On Aug. 19, 2016, 12:04 a.m., Jake Maes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51047/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2016, 12:04 a.m.)
>
>
> Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-1000
> https://issues.apache.org/jira/browse/SAMZA-1000
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-1000 Fix hello-samza documentation to not use latest branch by default
>
>
> Diffs
> -----
>
> docs/startup/hello-samza/versioned/index.md 8baacd390d41c5c87a426d63eec9ce5028de0cc2
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
>
> Diff: https://reviews.apache.org/r/51047/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jake Maes
>
>
Re: Review Request 51047: SAMZA-1000 Fix hello-samza documentation to
not use latest branch by default
Posted by Jake Maes <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51047/
-----------------------------------------------------------
(Updated Aug. 19, 2016, 12:04 a.m.)
Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
Bugs: SAMZA-1000
https://issues.apache.org/jira/browse/SAMZA-1000
Repository: samza
Description
-------
SAMZA-1000 Fix hello-samza documentation to not use latest branch by default
Diffs (updated)
-----
docs/startup/hello-samza/versioned/index.md 8baacd390d41c5c87a426d63eec9ce5028de0cc2
gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
Diff: https://reviews.apache.org/r/51047/diff/
Testing
-------
Thanks,
Jake Maes
Re: Review Request 51047: SAMZA-1000 Fix hello-samza documentation to
not use latest branch by default
Posted by Jake Maes <ja...@gmail.com>.
> On Aug. 16, 2016, 10:07 p.m., Yi Pan (Data Infrastructure) wrote:
> > docs/startup/hello-samza/versioned/index.md, line 53
> > <https://reviews.apache.org/r/51047/diff/3/?file=1473739#file1473739line53>
> >
> > We will still need to checkout latest hello-samza, if the instruction here does not include how to modify the pom.xml and the build.gradle files to point to the new SNAPSHOT version built from the master branch of samza repo.
> >
> > And if we do that, there actually is no reason to keep the latest branch in hello-samza, which may be a bigger scope of work. I would rather work on integrate hello-samza into the same repository as samza (SAMZA-205)
> >
> > So, weighing all the options, would it be better if we keep the latest version of hello-samza documentation include the checkout latest and make this publishToMavenLocal as mandatory, while removing both the checkout latest and the publishToMavenLocal in the released version of document?
>
> Jake Maes wrote:
> I thought we agreed that making ```publishToMavenLocal``` mandatory was against the spirit of hello-samza, which is to demonstrate how to create a project that depends on samza and then use it in 3 jobs. That's the "off the shelf" use case where users just depend on samza without building it from source, and I suspect it's the most common case.
>
> If we wanted to keep ```publishToMavenLocal``` mandatory, it seems we should more explicitly call out that this tutuorial expects you to have a local copy of samza. And if we do that, we're basically maintaining 2 versions of this tutorial; 1 for the latest and 1 for all released versions. With that in mind, my preference is to commonize all versions to not checkout latest or publishToMavenLocal. After all, this tutorial is not about testing samza changes in the hello-world project. If we needed such a tutorial, we could create a brief, separate, tutorial to explain that flow.
>
> Thoughts?
>
> Navina Ramesh wrote:
> Isn't ./bin/grid bootstrap the "off the shelf" experience you are referring to? It automatically checks out samza repository and publishes to maven?
> I think it is very useful to keep 2 branches in hello-samza. Master that operates on the latest released stable version of samza and the Latest branch that pretty much works out of samza master's head.
> Hence, the tutorial for latest and released versions should also be separate. In the "latest" (non-released) tutorial, a local copy of samza and mavenpublish is necessary. My 2 cents.
>
> Jake Maes wrote:
> >>Isn't ./bin/grid bootstrap the "off the shelf" experience you are referring to?
> No. "Off the shelf" would not involve any local source code for samza. Just a direct dependency on the maven artifacts.
As we discussed, the latest patch removes everything to do with the dev build of Samza and they will be put in the README.md of hello-samza. I will create a separate patch for the README.md changes.
- Jake
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51047/#review145916
-----------------------------------------------------------
On Aug. 19, 2016, 12:04 a.m., Jake Maes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51047/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2016, 12:04 a.m.)
>
>
> Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-1000
> https://issues.apache.org/jira/browse/SAMZA-1000
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-1000 Fix hello-samza documentation to not use latest branch by default
>
>
> Diffs
> -----
>
> docs/startup/hello-samza/versioned/index.md 8baacd390d41c5c87a426d63eec9ce5028de0cc2
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
>
> Diff: https://reviews.apache.org/r/51047/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jake Maes
>
>
Re: Review Request 51047: SAMZA-1000 Fix hello-samza documentation to
not use latest branch by default
Posted by Jake Maes <ja...@gmail.com>.
> On Aug. 16, 2016, 10:07 p.m., Yi Pan (Data Infrastructure) wrote:
> > docs/startup/hello-samza/versioned/index.md, line 53
> > <https://reviews.apache.org/r/51047/diff/3/?file=1473739#file1473739line53>
> >
> > We will still need to checkout latest hello-samza, if the instruction here does not include how to modify the pom.xml and the build.gradle files to point to the new SNAPSHOT version built from the master branch of samza repo.
> >
> > And if we do that, there actually is no reason to keep the latest branch in hello-samza, which may be a bigger scope of work. I would rather work on integrate hello-samza into the same repository as samza (SAMZA-205)
> >
> > So, weighing all the options, would it be better if we keep the latest version of hello-samza documentation include the checkout latest and make this publishToMavenLocal as mandatory, while removing both the checkout latest and the publishToMavenLocal in the released version of document?
I thought we agreed that making ```publishToMavenLocal``` mandatory was against the spirit of hello-samza, which is to demonstrate how to create a project that depends on samza and then use it in 3 jobs. That's the "off the shelf" use case where users just depend on samza without building it from source, and I suspect it's the most common case.
If we wanted to keep ```publishToMavenLocal``` mandatory, it seems we should more explicitly call out that this tutuorial expects you to have a local copy of samza. And if we do that, we're basically maintaining 2 versions of this tutorial; 1 for the latest and 1 for all released versions. With that in mind, my preference is to commonize all versions to not checkout latest or publishToMavenLocal. After all, this tutorial is not about testing samza changes in the hello-world project. If we needed such a tutorial, we could create a brief, separate, tutorial to explain that flow.
Thoughts?
- Jake
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51047/#review145916
-----------------------------------------------------------
On Aug. 15, 2016, 6:18 p.m., Jake Maes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51047/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2016, 6:18 p.m.)
>
>
> Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-1000
> https://issues.apache.org/jira/browse/SAMZA-1000
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-1000 Fix hello-samza documentation to not use latest branch by default
>
>
> Diffs
> -----
>
> docs/startup/hello-samza/versioned/index.md 8baacd390d41c5c87a426d63eec9ce5028de0cc2
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
>
> Diff: https://reviews.apache.org/r/51047/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jake Maes
>
>
Re: Review Request 51047: SAMZA-1000 Fix hello-samza documentation to
not use latest branch by default
Posted by Jake Maes <ja...@gmail.com>.
> On Aug. 16, 2016, 10:07 p.m., Yi Pan (Data Infrastructure) wrote:
> > docs/startup/hello-samza/versioned/index.md, line 53
> > <https://reviews.apache.org/r/51047/diff/3/?file=1473739#file1473739line53>
> >
> > We will still need to checkout latest hello-samza, if the instruction here does not include how to modify the pom.xml and the build.gradle files to point to the new SNAPSHOT version built from the master branch of samza repo.
> >
> > And if we do that, there actually is no reason to keep the latest branch in hello-samza, which may be a bigger scope of work. I would rather work on integrate hello-samza into the same repository as samza (SAMZA-205)
> >
> > So, weighing all the options, would it be better if we keep the latest version of hello-samza documentation include the checkout latest and make this publishToMavenLocal as mandatory, while removing both the checkout latest and the publishToMavenLocal in the released version of document?
>
> Jake Maes wrote:
> I thought we agreed that making ```publishToMavenLocal``` mandatory was against the spirit of hello-samza, which is to demonstrate how to create a project that depends on samza and then use it in 3 jobs. That's the "off the shelf" use case where users just depend on samza without building it from source, and I suspect it's the most common case.
>
> If we wanted to keep ```publishToMavenLocal``` mandatory, it seems we should more explicitly call out that this tutuorial expects you to have a local copy of samza. And if we do that, we're basically maintaining 2 versions of this tutorial; 1 for the latest and 1 for all released versions. With that in mind, my preference is to commonize all versions to not checkout latest or publishToMavenLocal. After all, this tutorial is not about testing samza changes in the hello-world project. If we needed such a tutorial, we could create a brief, separate, tutorial to explain that flow.
>
> Thoughts?
>
> Navina Ramesh wrote:
> Isn't ./bin/grid bootstrap the "off the shelf" experience you are referring to? It automatically checks out samza repository and publishes to maven?
> I think it is very useful to keep 2 branches in hello-samza. Master that operates on the latest released stable version of samza and the Latest branch that pretty much works out of samza master's head.
> Hence, the tutorial for latest and released versions should also be separate. In the "latest" (non-released) tutorial, a local copy of samza and mavenpublish is necessary. My 2 cents.
>>Isn't ./bin/grid bootstrap the "off the shelf" experience you are referring to?
No. "Off the shelf" would not involve any local source code for samza. Just a direct dependency on the maven artifacts.
- Jake
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51047/#review145916
-----------------------------------------------------------
On Aug. 15, 2016, 6:18 p.m., Jake Maes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51047/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2016, 6:18 p.m.)
>
>
> Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-1000
> https://issues.apache.org/jira/browse/SAMZA-1000
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-1000 Fix hello-samza documentation to not use latest branch by default
>
>
> Diffs
> -----
>
> docs/startup/hello-samza/versioned/index.md 8baacd390d41c5c87a426d63eec9ce5028de0cc2
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
>
> Diff: https://reviews.apache.org/r/51047/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jake Maes
>
>
Re: Review Request 51047: SAMZA-1000 Fix hello-samza documentation to
not use latest branch by default
Posted by Navina Ramesh <nr...@linkedin.com>.
> On Aug. 16, 2016, 10:07 p.m., Yi Pan (Data Infrastructure) wrote:
> > docs/startup/hello-samza/versioned/index.md, line 53
> > <https://reviews.apache.org/r/51047/diff/3/?file=1473739#file1473739line53>
> >
> > We will still need to checkout latest hello-samza, if the instruction here does not include how to modify the pom.xml and the build.gradle files to point to the new SNAPSHOT version built from the master branch of samza repo.
> >
> > And if we do that, there actually is no reason to keep the latest branch in hello-samza, which may be a bigger scope of work. I would rather work on integrate hello-samza into the same repository as samza (SAMZA-205)
> >
> > So, weighing all the options, would it be better if we keep the latest version of hello-samza documentation include the checkout latest and make this publishToMavenLocal as mandatory, while removing both the checkout latest and the publishToMavenLocal in the released version of document?
>
> Jake Maes wrote:
> I thought we agreed that making ```publishToMavenLocal``` mandatory was against the spirit of hello-samza, which is to demonstrate how to create a project that depends on samza and then use it in 3 jobs. That's the "off the shelf" use case where users just depend on samza without building it from source, and I suspect it's the most common case.
>
> If we wanted to keep ```publishToMavenLocal``` mandatory, it seems we should more explicitly call out that this tutuorial expects you to have a local copy of samza. And if we do that, we're basically maintaining 2 versions of this tutorial; 1 for the latest and 1 for all released versions. With that in mind, my preference is to commonize all versions to not checkout latest or publishToMavenLocal. After all, this tutorial is not about testing samza changes in the hello-world project. If we needed such a tutorial, we could create a brief, separate, tutorial to explain that flow.
>
> Thoughts?
Isn't ./bin/grid bootstrap the "off the shelf" experience you are referring to? It automatically checks out samza repository and publishes to maven?
I think it is very useful to keep 2 branches in hello-samza. Master that operates on the latest released stable version of samza and the Latest branch that pretty much works out of samza master's head.
Hence, the tutorial for latest and released versions should also be separate. In the "latest" (non-released) tutorial, a local copy of samza and mavenpublish is necessary. My 2 cents.
- Navina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51047/#review145916
-----------------------------------------------------------
On Aug. 15, 2016, 6:18 p.m., Jake Maes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51047/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2016, 6:18 p.m.)
>
>
> Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-1000
> https://issues.apache.org/jira/browse/SAMZA-1000
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-1000 Fix hello-samza documentation to not use latest branch by default
>
>
> Diffs
> -----
>
> docs/startup/hello-samza/versioned/index.md 8baacd390d41c5c87a426d63eec9ce5028de0cc2
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
>
> Diff: https://reviews.apache.org/r/51047/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jake Maes
>
>
Re: Review Request 51047: SAMZA-1000 Fix hello-samza documentation to
not use latest branch by default
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51047/#review145916
-----------------------------------------------------------
docs/startup/hello-samza/versioned/index.md (line 52)
<https://reviews.apache.org/r/51047/#comment212272>
We will still need to checkout latest hello-samza, if the instruction here does not include how to modify the pom.xml and the build.gradle files to point to the new SNAPSHOT version built from the master branch of samza repo.
And if we do that, there actually is no reason to keep the latest branch in hello-samza, which may be a bigger scope of work. I would rather work on integrate hello-samza into the same repository as samza (SAMZA-205)
So, weighing all the options, would it be better if we keep the latest version of hello-samza documentation include the checkout latest and make this publishToMavenLocal as mandatory, while removing both the checkout latest and the publishToMavenLocal in the released version of document?
- Yi Pan (Data Infrastructure)
On Aug. 15, 2016, 6:18 p.m., Jake Maes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51047/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2016, 6:18 p.m.)
>
>
> Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-1000
> https://issues.apache.org/jira/browse/SAMZA-1000
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-1000 Fix hello-samza documentation to not use latest branch by default
>
>
> Diffs
> -----
>
> docs/startup/hello-samza/versioned/index.md 8baacd390d41c5c87a426d63eec9ce5028de0cc2
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
>
> Diff: https://reviews.apache.org/r/51047/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jake Maes
>
>
Re: Review Request 51047: SAMZA-1000 Fix hello-samza documentation to
not use latest branch by default
Posted by Jake Maes <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51047/
-----------------------------------------------------------
(Updated Aug. 15, 2016, 6:18 p.m.)
Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
Bugs: SAMZA-1000
https://issues.apache.org/jira/browse/SAMZA-1000
Repository: samza
Description
-------
SAMZA-1000 Fix hello-samza documentation to not use latest branch by default
Diffs (updated)
-----
docs/startup/hello-samza/versioned/index.md 8baacd390d41c5c87a426d63eec9ce5028de0cc2
gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
Diff: https://reviews.apache.org/r/51047/diff/
Testing
-------
Thanks,
Jake Maes
Re: Review Request 51047: SAMZA-1000 Fix hello-samza documentation to
not use latest branch by default
Posted by Jake Maes <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51047/
-----------------------------------------------------------
(Updated Aug. 15, 2016, 6:17 p.m.)
Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
Bugs: SAMZA-1000
https://issues.apache.org/jira/browse/SAMZA-1000
Repository: samza
Description
-------
SAMZA-1000 Fix hello-samza documentation to not use latest branch by default
Diffs (updated)
-----
docs/startup/hello-samza/versioned/index.md 8baacd390d41c5c87a426d63eec9ce5028de0cc2
Diff: https://reviews.apache.org/r/51047/diff/
Testing
-------
Thanks,
Jake Maes