[jira] [Commented] (FLINK-7427) integrate PartitionRequestProtocol into NettyProtocol

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123108#comment-16123108 ] 

ASF GitHub Bot commented on FLINK-7427:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4528

    [FLINK-7427][network] integrate PartitionRequestProtocol into NettyProtocol

    ## What is the purpose of the change
    
    This is to make the network protocol classes more understandable by removing one unnecessary level of abstraction.
    
    ## Brief change log
    
    - integrate `PartitionRequestProtocol` into `NettyProtocol`
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup covered by existing network tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (yes / no / don't know)
      - The runtime per-record code paths (performance sensitive): (code-path yes, performance no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (JavaDocs)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-7427

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4528.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4528
    
----
commit 1c0e5aae05f3e4eaec986792b508a08ee242ac73
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-08-10T14:58:19Z

    [FLINK-7427][network] integrate PartitionRequestProtocol into NettyProtocol
    
    - removes one level of (unneeded) abstraction for clarity

----


> integrate PartitionRequestProtocol into NettyProtocol
> -----------------------------------------------------
>
>                 Key: FLINK-7427
>                 URL: https://issues.apache.org/jira/browse/FLINK-7427
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Minor
>
> Back when the current network stack was created, an interface {{NettyProtocol}} was defined with the only implementing class being {{PartitionRequestProtocol}}, except for unit tests which were, however, also partly based on {{PartitionRequestProtocol}}.
> To make things a bit simpler, we should integrate {{PartitionRequestProtocol}}—which only defines the channel handlers to use by the client and server—into {{NettyProtocol}} and clean up a bit.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)