You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/14 22:48:27 UTC

[GitHub] vdantu opened a new pull request #12169: Remove fixed seed for test_huber_loss test

vdantu opened a new pull request #12169: Remove fixed seed for test_huber_loss test
URL: https://github.com/apache/incubator-mxnet/pull/12169
 
 
   ## Description ##
   (Brief description on what this PR is about)
   Fix for issue #11696 
   Removed the fixed seed for the test "test_huber_loss". Ran this test 10,000 times on a GPU host and didn't see any issue. 
   
   Ran:
   ```
    $ MXNET_TEST_COUNT=10000 nosetests --logging-level=DEBUG --verbose -s test_operator_gpu:test_huber_loss
   .......
   [DEBUG] 9996 of 10000: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=966105224 to reproduce.
   [DEBUG] 9997 of 10000: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=1565596372 to reproduce.
   [DEBUG] 9998 of 10000: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=1471737541 to reproduce.
   [DEBUG] 9999 of 10000: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=1224967521 to reproduce.
   [DEBUG] 10000 of 10000: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=1901892319 to reproduce.
   ok
   
   ----------------------------------------------------------------------
   Ran 1 test in 10227.998s
   
   OK
   $
   ```
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services