You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Ross Gardler (JIRA)" <ji...@apache.org> on 2006/02/08 13:19:01 UTC
[jira] Commented: (FOR-559) FAQ+TOC problem: force-toc option
[ http://issues.apache.org/jira/browse/FOR-559?page=comments#action_12365549 ]
Ross Gardler commented on FOR-559:
----------------------------------
What do Forrest devs think of this patch, I'm not sure about applying it because it appears to be a workaround not a solution.
What it does is add a meta-information value to a documents header:
<header>
<title><xsl:value-of select="@title"/></title>
+ <meta name="forrest.force-toc">true</meta>
</header>
And then uses this to decide on whether or not to display a TOC:
- <xsl:if test="count(//tocitems/tocitem) >= $config/toc/@min-sections">
+ <xsl:if test="(count(//tocitems/tocitem) >= $config/toc/@min-sections) or (//tocitems/@force = 'true')">
I'm +0 on applying this on the grounds that it solves a users problem and that the core problem can be more completely resolved when the dispatcher is utilised.
> FAQ+TOC problem: force-toc option
> ---------------------------------
>
> Key: FOR-559
> URL: http://issues.apache.org/jira/browse/FOR-559
> Project: Forrest
> Type: New Feature
> Components: Skins (general issues)
> Versions: 0.6, 0.7, 0.8-dev
> Reporter: Jeremias Maerki
> Priority: Minor
> Attachments: forrest-force-toc.diff
>
> This is a hybrid patch/RFE/bugfix. Today, I've taken another stab at the problem Clay Leeds reported to you in May:
> http://www.mail-archive.com/user@forrest.apache.org/msg00528.html
> We have the problem in FOP that the TOC for the FAQ page isn't generated.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (FOR-559) FAQ+TOC problem: force-toc option
Posted by Thorsten Scherler <th...@wyona.com>.
El mié, 08-02-2006 a las 13:19 +0100, Ross Gardler (JIRA) escribió:
> [ http://issues.apache.org/jira/browse/FOR-559?page=comments#action_12365549 ]
>
> Ross Gardler commented on FOR-559:
> ----------------------------------
>
> What do Forrest devs think of this patch, I'm not sure about applying it because it appears to be a workaround not a solution.
>
> What it does is add a meta-information value to a documents header:
>
> <header>
> <title><xsl:value-of select="@title"/></title>
> + <meta name="forrest.force-toc">true</meta>
> </header>
>
> And then uses this to decide on whether or not to display a TOC:
>
> - <xsl:if test="count(//tocitems/tocitem) >= $config/toc/@min-sections">
> + <xsl:if test="(count(//tocitems/tocitem) >= $config/toc/@min-sections) or (//tocitems/@force = 'true')">
>
> I'm +0 on applying this on the grounds that it solves a users problem and that the core problem can be more completely resolved when the dispatcher is utilised.
>
+0, like you stated it is an old fashion skins workaround. ;-) Seems to
not hurt anything, but it is solved in the dispatcher.
salu2
--
Thorsten Scherler
COO Spain
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
thorsten.scherler@wyona.com thorsten@apache.org