You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/10/28 20:07:48 UTC

[GitHub] [trafficserver] zwoop opened a new pull request #8469: Make factory.response_suppression_mode an overridable config

zwoop opened a new pull request #8469:
URL: https://github.com/apache/trafficserver/pull/8469


   This changes proxy.config.body_factory.response_suppression_mode to be
   an overridable configuration in the Http "state". This can be used to avoid
   having body factory populating a body when it's undeseriable.
   
   A typical use case would be e.g. this configuration for HRW:
   
   cond %{REMAP_PSEUDO_HOOK}
       set-redirect 302 http://www.example.com
       set-config proxy.config.body_factory.response_suppression_mode 1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] zwoop commented on pull request #8469: Make factory.response_suppression_mode an overridable config

Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8469:
URL: https://github.com/apache/trafficserver/pull/8469#issuecomment-955139621


   @sudheerv  No, thank you for fixing the bug :-).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] SolidWallOfCode commented on pull request #8469: Make factory.response_suppression_mode an overridable config

Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on pull request #8469:
URL: https://github.com/apache/trafficserver/pull/8469#issuecomment-954165771


   Why is it a configuration variable, instead of just a member with API to change it? Is anyone actually going to put it in "records.config"?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] zwoop commented on pull request #8469: Make factory.response_suppression_mode an overridable config

Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8469:
URL: https://github.com/apache/trafficserver/pull/8469#issuecomment-963659632


   Cherry-picked to v9.2.x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] zwoop merged pull request #8469: Make factory.response_suppression_mode an overridable config

Posted by GitBox <gi...@apache.org>.
zwoop merged pull request #8469:
URL: https://github.com/apache/trafficserver/pull/8469


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] zwoop commented on pull request #8469: Make factory.response_suppression_mode an overridable config

Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8469:
URL: https://github.com/apache/trafficserver/pull/8469#issuecomment-954174541


   @SolidWallOfCode well, it's always been a configuration option, I don't know why, or who's using it. I'm certainly not opposed to removing it, and turn it into a "Cntl" API setting, but that would be incompatible with 9.x.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org