[GitHub] [madlib] njayaram2 commented on a change in pull request #385: DL: Make metrics and loss optional compile parameters

[GitBox <gi...@apache.org>]

njayaram2 commented on a change in pull request #385: DL: Make metrics and loss optional compile parameters
URL: https://github.com/apache/madlib/pull/385#discussion_r281310170
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/madlib_keras_wrapper.py_in
 ##########
 @@ -131,17 +131,26 @@ def parse_and_validate_compile_params(str_of_args):
         compile_dict:           Dictionary of arguments for keras.compile
     """
 
-    compile_dict = convert_string_of_args_to_dict(str_of_args)
-
-    opt_name,opt_args = parse_optimizer(compile_dict)
-    compile_dict['loss'] = parse_loss(compile_dict)
     literal_eval_compile_params = ['metrics', 'loss_weights',
                                    'weighted_metrics', 'sample_weight_mode']
     accepted_compile_params = literal_eval_compile_params + ['optimizer', 'loss']
 
+    compile_dict = convert_string_of_args_to_dict(str_of_args)
     compile_dict = validate_and_literal_eval_keys(compile_dict,
                                                   literal_eval_compile_params,
                                                   accepted_compile_params)
+
+    if 'optimizer' in compile_dict.keys():
+        opt_name,opt_args = parse_optimizer(compile_dict)
+    else:
+        plpy.error("optimizer is a required parameter for compile")
+
+
+    if 'loss' in compile_dict.keys():
+        compile_dict['loss'] = parse_loss(compile_dict)
+    else:
+        plpy.error("loss is a required parameter for compile")
+
 
 Review comment:
   A minor coding style comment, we could use `_assert` instead of if-else blocks here:
   ```
   _assert('optimizer' in compile_dict.keys(), "optimizer is a required parameter for compile")
   opt_name, opt_args = parse_optimizer(compile_dict)
   
   _assert('loss' in compile_dict.keys(), "loss is a required parameter for compile")
   compile_dict['loss'] = parse_loss(compile_dict)
   
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services