You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/01/20 05:20:03 UTC
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #221: [YUNIKORN-508] Fixing the log collection path for upstream runs
yangwwei commented on a change in pull request #221:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/221#discussion_r560600807
##########
File path: test/e2e/framework/configmanager/config.go
##########
@@ -61,6 +61,6 @@ func (c *YuniKornTestConfigType) ParseFlags() {
"External Port of YuniKorn service")
flag.StringVar(&c.YkScheme, "yk-scheme", DefaultYuniKornScheme,
"Scheme of YuniKron Service")
- flag.StringVar(&c.LogDir, "log-dir", "/yunikorn-qe/test-results/target/failsafe-reports",
+ flag.StringVar(&c.LogDir, "log-dir", "/tmp/test-results/target/failsafe-reports",
Review comment:
instead of hard coding to /tmp, is it better to create a tmp dir with https://yourbasic.org/golang/temporary-file-directory for the job?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org