You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Suma Shivaprasad <su...@gmail.com> on 2017/01/31 06:47:24 UTC
Review Request 56113: Fixed issues with deletion during updates
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56113/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1509
https://issues.apache.org/jira/browse/ATLAS-1509
Repository: atlas
Description
-------
Added tests for deletion during updates and fixed issues found
Diffs
-----
intg/src/test/java/org/apache/atlas/TestUtilsV2.java 4f2916c
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 48bb77e
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 34e02c6
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java c98d340
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java 22851ca
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java c902f81
repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java bb8c223
server-api/src/main/java/org/apache/atlas/RequestContextV1.java 1fc11a2
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java 75a7183
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java 8777510
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 47e1fa3
Diff: https://reviews.apache.org/r/56113/diff/
Testing
-------
Thanks,
Suma Shivaprasad
Re: Review Request 56113: Fixed issues with deletion during updates
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56113/#review163787
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java (line 167)
<https://reviews.apache.org/r/56113/#comment235287>
I think this can be simplified to Optional.fromNullable(currentEdge), internally it'll do the same comparison.
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java (line 76)
<https://reviews.apache.org/r/56113/#comment235286>
ret1 ==> entityWithAssociations
- Apoorv Naik
On Feb. 1, 2017, midnight, Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56113/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, midnight)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1509
> https://issues.apache.org/jira/browse/ATLAS-1509
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Added tests for deletion during updates and fixed issues found
>
>
> Diffs
> -----
>
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java 4f2916c
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 48bb77e
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 34e02c6
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java c98d340
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java 22851ca
> repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java 25bae44
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java c902f81
> repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java bb8c223
> server-api/src/main/java/org/apache/atlas/RequestContextV1.java 1fc11a2
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java 75a7183
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java 8777510
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 47e1fa3
>
> Diff: https://reviews.apache.org/r/56113/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 56113: Fixed issues with deletion during updates
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56113/#review163797
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java (line 242)
<https://reviews.apache.org/r/56113/#comment235303>
Didn't understand why the code has been commented. Won't this result into stray edges of reverse attribute references
- Vimal Sharma
On Feb. 1, 2017, midnight, Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56113/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, midnight)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1509
> https://issues.apache.org/jira/browse/ATLAS-1509
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Added tests for deletion during updates and fixed issues found
>
>
> Diffs
> -----
>
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java 4f2916c
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 48bb77e
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 34e02c6
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java c98d340
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java 22851ca
> repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java 25bae44
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java c902f81
> repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java bb8c223
> server-api/src/main/java/org/apache/atlas/RequestContextV1.java 1fc11a2
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java 75a7183
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java 8777510
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 47e1fa3
>
> Diff: https://reviews.apache.org/r/56113/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 56113: Fixed issues with deletion during updates
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56113/#review163881
-----------------------------------------------------------
Ship it!
Suma - I merged this patch with other recent changes. I will commit this patch shortly. Thanks!
- Madhan Neethiraj
On Feb. 1, 2017, midnight, Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56113/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, midnight)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1509
> https://issues.apache.org/jira/browse/ATLAS-1509
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Added tests for deletion during updates and fixed issues found
>
>
> Diffs
> -----
>
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java 4f2916c
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 48bb77e
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 34e02c6
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java c98d340
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java 22851ca
> repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java 25bae44
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java c902f81
> repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java bb8c223
> server-api/src/main/java/org/apache/atlas/RequestContextV1.java 1fc11a2
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java 75a7183
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java 8777510
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 47e1fa3
>
> Diff: https://reviews.apache.org/r/56113/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 56113: Fixed issues with deletion during updates
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56113/
-----------------------------------------------------------
(Updated Feb. 1, 2017, midnight)
Review request for atlas.
Bugs: ATLAS-1509
https://issues.apache.org/jira/browse/ATLAS-1509
Repository: atlas
Description
-------
Added tests for deletion during updates and fixed issues found
Diffs (updated)
-----
intg/src/test/java/org/apache/atlas/TestUtilsV2.java 4f2916c
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 48bb77e
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 34e02c6
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java c98d340
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java 22851ca
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java 25bae44
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java c902f81
repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java bb8c223
server-api/src/main/java/org/apache/atlas/RequestContextV1.java 1fc11a2
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java 75a7183
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java 8777510
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 47e1fa3
Diff: https://reviews.apache.org/r/56113/diff/
Testing
-------
Thanks,
Suma Shivaprasad
Re: Review Request 56113: Fixed issues with deletion during updates
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56113/
-----------------------------------------------------------
(Updated Jan. 31, 2017, 11:57 p.m.)
Review request for atlas.
Changes
-------
Fixed review comments and tests
Bugs: ATLAS-1509
https://issues.apache.org/jira/browse/ATLAS-1509
Repository: atlas
Description
-------
Added tests for deletion during updates and fixed issues found
Diffs (updated)
-----
intg/src/test/java/org/apache/atlas/TestUtilsV2.java 4f2916c
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 48bb77e
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 34e02c6
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java c98d340
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java 22851ca
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java 25bae44
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java c902f81
repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java bb8c223
server-api/src/main/java/org/apache/atlas/RequestContextV1.java 1fc11a2
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java 75a7183
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java 8777510
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 47e1fa3
Diff: https://reviews.apache.org/r/56113/diff/
Testing
-------
Thanks,
Suma Shivaprasad
Re: Review Request 56113: Fixed issues with deletion during updates
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56113/#review163634
-----------------------------------------------------------
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java (line 591)
<https://reviews.apache.org/r/56113/#comment235110>
(actualList != null || ((actualList != null && actualList.size() > 0)) ==>
CollectionUtils.isNotEmpty(actualList)
- Madhan Neethiraj
On Jan. 31, 2017, 6:47 a.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56113/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 6:47 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1509
> https://issues.apache.org/jira/browse/ATLAS-1509
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Added tests for deletion during updates and fixed issues found
>
>
> Diffs
> -----
>
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java 4f2916c
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 48bb77e
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 34e02c6
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java c98d340
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java 22851ca
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java c902f81
> repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java bb8c223
> server-api/src/main/java/org/apache/atlas/RequestContextV1.java 1fc11a2
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java 75a7183
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java 8777510
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 47e1fa3
>
> Diff: https://reviews.apache.org/r/56113/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Suma Shivaprasad
>
>