You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/15 07:37:13 UTC
[GitHub] [incubator-nuttx] Donny9 opened a new pull request #3718: sched/init: don't check remain stack for idle task
Donny9 opened a new pull request #3718:
URL: https://github.com/apache/incubator-nuttx/pull/3718
## Summary
We shouldn't check the remain stack for idle task because tt may not have been colored.
Change-Id: I0bd5808efabd395157d2530f2423b18f0c1eeabd
Signed-off-by: Jiuzhu Dong <do...@xiaomi.com>
## Impact
no
## Testing
daily test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3718: sched/init: don't check remain stack for idle task
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #3718:
URL: https://github.com/apache/incubator-nuttx/pull/3718#issuecomment-841850449
Ah I see, could we create a Kconfig that is set for arch that do colorize the idle stack correctly with the idea that eventually it can go away?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3718: sched/init: don't check remain stack for idle task
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #3718:
URL: https://github.com/apache/incubator-nuttx/pull/3718#issuecomment-841686035
In what cases is it not colored? The only case I can think of is the sim since is dynamically grows. Seems like in the case the would be better driven by a config flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #3718: sched/init: don't check remain stack for idle task
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #3718:
URL: https://github.com/apache/incubator-nuttx/pull/3718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Donny9 commented on pull request #3718: sched/init: don't check remain stack for idle task
Posted by GitBox <gi...@apache.org>.
Donny9 commented on pull request #3718:
URL: https://github.com/apache/incubator-nuttx/pull/3718#issuecomment-841943374
> Ah I see, could we create a Kconfig that is set for arch that do colorize the idle stack correctly with the idea that eventually it can go away?
ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3718: sched/init: don't check remain stack for idle task
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3718:
URL: https://github.com/apache/incubator-nuttx/pull/3718#issuecomment-841844978
It isn't only for sim, but many soc doesn't setup idle thread stack color correctly: https://github.com/apache/incubator-nuttx/issues/1769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Donny9 commented on pull request #3718: sched/init: don't check remain stack for idle task
Posted by GitBox <gi...@apache.org>.
Donny9 commented on pull request #3718:
URL: https://github.com/apache/incubator-nuttx/pull/3718#issuecomment-841943374
> Ah I see, could we create a Kconfig that is set for arch that do colorize the idle stack correctly with the idea that eventually it can go away?
ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3718: sched/init: don't check remain stack for idle task
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3718:
URL: https://github.com/apache/incubator-nuttx/pull/3718#issuecomment-858646731
Close since all idle thread stack colorize now with #3888.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3718: sched/init: don't check remain stack for idle task
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #3718:
URL: https://github.com/apache/incubator-nuttx/pull/3718#issuecomment-841850449
Ah I see, could we create a Kconfig that is set for arch that do colorize the idle stack correctly with the idea that eventually it can go away?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3718: sched/init: don't check remain stack for idle task
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3718:
URL: https://github.com/apache/incubator-nuttx/pull/3718#issuecomment-841844978
It isn't only for sim, but many soc doesn't setup idle thread stack color correctly: https://github.com/apache/incubator-nuttx/issues/1769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org