DO NOT REPLY [Bug 52183] New: SyncTimer could be improved (performance+reliability)

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=52183

             Bug #: 52183
           Summary: SyncTimer could be improved (performance+reliability)
           Product: JMeter
           Version: Nightly (Please specify date)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Main
        AssignedTo: issues@jmeter.apache.org
        ReportedBy: p.mouawad@ubik-ingenierie.com
    Classification: Unclassified


NIghtly r1201923

SyncTimer calls sync.wait outside of a loop which according to :
http://download.oracle.com/javase/6/docs/api/java/lang/Object.html#notifyAll%28%29

is wrong.

Furthermore, java.util.concurrent.CyclicBarrier would be a better solution to
the current implementation and would greatly simplify it.

The only remaining pb to this is when GroupSize is set to 0.
As cyclicBarrier must be created in test plan start,
JMeterContextService.getContext().getThreadGroup().getNumThreads() is not
available at this time.

Sebb, do you know how to get this information at test plan start ?

Thanks

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52183] SyncTimer could be improved (performance+reliability)

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=52183

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om
         Resolution|                            |FIXED

--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> 2011-11-23 22:34:17 UTC ---
Date: Wed Nov 23 22:33:32 2011
New Revision: 1205639

URL: http://svn.apache.org/viewvc?rev=1205639&view=rev
Log:
Bug 52183 - SyncTimer could be improved (performance+reliability)

Added:
   jmeter/trunk/src/components/org/apache/jmeter/timers/BarrierWrapper.java  
(with props)
   jmeter/trunk/src/components/org/apache/jmeter/timers/SyncTimer.java
Modified:
   jmeter/trunk/xdocs/changes.xml

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52183] SyncTimer could be improved (performance+reliability)

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=52183

--- Comment #1 from Sebb <se...@apache.org> 2011-11-15 17:29:28 UTC ---
The testStarted() methods are called before any thread groups are created.
There may be multiple groups with different counts so it's not possible to
provide the thread group count.

The ThreadListener interface is called after the thread group has been created,
so it might be possible to create the barrier there.

The ThreadListener method will need to enure that the barrier is only created
once for each Thread Group.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.