You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2016/07/14 19:55:24 UTC
[GitHub] flink pull request #2251: [FLINK-4212] [scripts] Lock PID file when starting...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2251
[FLINK-4212] [scripts] Lock PID file when starting daemons
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 4212_lock_pid_file_when_starting_daemons
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2251.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2251
----
commit e7d59835ab011e38de61a0b304cd93f1ca7cefb7
Author: Greg Hogan <co...@greghogan.com>
Date: 2016-07-14T15:55:41Z
[FLINK-4212] [scripts] Lock PID file when starting daemons
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2251: [FLINK-4212] [scripts] Lock PID file when starting daemon...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2251
This works on my machine (Ubuntu Linux 14.04)
Can someone verify it for MacOS? (@uce, @aljoscha, @tillrohrmann)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2251: [FLINK-4212] [scripts] Lock PID file when starting...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan closed the pull request at:
https://github.com/apache/flink/pull/2251
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2251: [FLINK-4212] [scripts] Lock PID file when starting daemon...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2251
Looks like it is available in Linux and BSD but not MacOS. We can skip locking if `flock` is not available. The race condition only manifests when starting duplicate managers on the same system in parallel.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2251: [FLINK-4212] [scripts] Lock PID file when starting daemon...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2251
Merging this ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2251: [FLINK-4212] [scripts] Lock PID file when starting daemon...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2251
Is the `flock` command available by default on the common UNIX-style OSs?
Ubuntu has it by default, what about MacOS?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2251: [FLINK-4212] [scripts] Lock PID file when starting daemon...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2251
Checked it out locally and all processes start up as expected. @greghogan I think it's good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---