You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/07/31 12:57:34 UTC
[GitHub] [maven-enforcer] raupachz opened a new pull request, #178: [MENFORCER-397] allow no rules
raupachz opened a new pull request, #178:
URL: https://github.com/apache/maven-enforcer/pull/178
Hi there,
attached is another `up-for-grabs`. This PR allows no rules by adding a `failIfNoRules` parameter. Settings `failIfNoRules` to false will log a warning "No rules are configured" instead of throwing an exception. Default behaviour is to throw an exception if there are no rules configured. Like people are used to.
A suitable test case has been added.
Feedback is welcome.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MENFORCER-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski merged pull request #178: [MENFORCER-397] allow no rules
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #178:
URL: https://github.com/apache/maven-enforcer/pull/178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] raupachz commented on pull request #178: [MENFORCER-397] allow no rules
Posted by GitBox <gi...@apache.org>.
raupachz commented on PR #178:
URL: https://github.com/apache/maven-enforcer/pull/178#issuecomment-1200420709
My bad. Let me check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #178: [MENFORCER-397] allow no rules
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #178:
URL: https://github.com/apache/maven-enforcer/pull/178#discussion_r933989353
##########
maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java:
##########
@@ -97,6 +97,12 @@
@Parameter( property = "enforcer.failFast", defaultValue = "false" )
private boolean failFast = false;
+ /**
+ * Set this to "true" to cause a failure if there are no rules to execute
+ */
+ @Parameter( property = "enforcer.failIfNoRules", defaultValue = "true" )
Review Comment:
Pleas add `@since`
Yes - I see that other parameters also has missing it ... we can fix for rest in separate PR
It is used for documentation: https://maven.apache.org/enforcer/maven-enforcer-plugin/enforce-mojo.html
Maybe documentation - similar to other, eg:
```
Flag to allow executions without rules.
```
##########
maven-enforcer-plugin/src/test/java/org/apache/maven/plugins/enforcer/TestEnforceMojo.java:
##########
@@ -296,6 +296,14 @@ public void testLoggingOnEnforcerRuleExceptionWithoutMessage()
Mockito.verify( logSpy ).warn( Mockito.matches( ".* failed with message:" + System.lineSeparator() + "null" ) );
}
+ @Test
+ public void testFailIfNoTests()
+ throws MojoExecutionException {
+ setupBasics( false );
+ mojo.setFailIfNoRules( false );
+ mojo.execute();
+ }
Review Comment:
please add some assertions, eg that `log.warn` was called only once with specific message and no more interactions on `log`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org