You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@gmail.com> on 2022/04/14 16:25:50 UTC
Review Request 73945: RANGER-3709: Fix NullPointerException in getSecureServicePoliciesIfUpdated call of ServiceRest
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73945/
-----------------------------------------------------------
Review request for ranger, bhavik patel, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3709
https://issues.apache.org/jira/browse/RANGER-3709
Repository: ranger
Description
-------
**Problem Statement:** if servicePolicies object is null then following error message may appear in the log file with long stacktrace.
java.lang.NullPointerException
at org.apache.ranger.common.RangerServicePoliciesCache$ServicePoliciesWrapper.getLatestOrCached(RangerServicePoliciesCache.java:231)
at org.apache.ranger.common.RangerServicePoliciesCache.getServicePolicies(RangerServicePoliciesCache.java:125)
at org.apache.ranger.biz.ServiceDBStore.getServicePoliciesIfUpdated(ServiceDBStore.java:2797)
at org.apache.ranger.rest.ServiceREST.getSecureServicePoliciesIfUpdated(ServiceREST.java:3140)
**Proposed Statement:**
Add a null check and accordingly print the Policy Version.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java 061b14cbd
Diff: https://reviews.apache.org/r/73945/diff/1/
Testing
-------
Tested with patch and can see following message.
2022-04-14 15:07:29,557 ERROR org.apache.ranger.common.RangerServicePoliciesCache: Could not get lock in [10] seconds, returning cached ServicePolicies and wait Queue Length:[0], servicePolicies version:[-1]
Thanks,
Pradeep Agrawal
Re: Review Request 73945: RANGER-3709: Fix NullPointerException in getSecureServicePoliciesIfUpdated call of ServiceRest
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73945/#review224320
-----------------------------------------------------------
Ship it!
Ship It!
- Ramesh Mani
On April 14, 2022, 4:25 p.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73945/
> -----------------------------------------------------------
>
> (Updated April 14, 2022, 4:25 p.m.)
>
>
> Review request for ranger, bhavik patel, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3709
> https://issues.apache.org/jira/browse/RANGER-3709
>
>
> Repository: ranger
>
>
> Description
> -------
>
> **Problem Statement:** if servicePolicies object is null then following error message may appear in the log file with long stacktrace.
> java.lang.NullPointerException
> at org.apache.ranger.common.RangerServicePoliciesCache$ServicePoliciesWrapper.getLatestOrCached(RangerServicePoliciesCache.java:231)
> at org.apache.ranger.common.RangerServicePoliciesCache.getServicePolicies(RangerServicePoliciesCache.java:125)
> at org.apache.ranger.biz.ServiceDBStore.getServicePoliciesIfUpdated(ServiceDBStore.java:2797)
> at org.apache.ranger.rest.ServiceREST.getSecureServicePoliciesIfUpdated(ServiceREST.java:3140)
>
> **Proposed Statement:**
> Add a null check and accordingly print the Policy Version.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java 061b14cbd
>
>
> Diff: https://reviews.apache.org/r/73945/diff/1/
>
>
> Testing
> -------
>
> Tested with patch and can see following message.
>
> 2022-04-14 15:07:29,557 ERROR org.apache.ranger.common.RangerServicePoliciesCache: Could not get lock in [10] seconds, returning cached ServicePolicies and wait Queue Length:[0], servicePolicies version:[-1]
>
>
> Thanks,
>
> Pradeep Agrawal
>
>