[GitHub] [arrow] xhochy commented on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

[GitBox <gi...@apache.org>]

xhochy commented on pull request #7593:
URL: https://github.com/apache/arrow/pull/7593#issuecomment-652195053


   I think prefixes make sense. We will have sometime similar kernel names that act quite different depending on the types they work on. I would differentiate in the string/binary case the kernels between the categories:
   
   * `binary_`: works on any binary data
   * `ascii_`: works on string data but is limited ASCII-only characters
   * `utf8_`: works on string data and respects UTF8-encoding or even makes use of an UTF8-symbol table (i.e. `utf8proc`).
   
   With that, I would rename the kernel here to `binary_contains_exact`. The `exact` suffix is important for me as I intent to implement also `ut8_contains_case_insensitve`, `binary_contains_regex` (or should this be string/utf8?), `utf8_contains_regex_case_insensitve`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org