You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jesse Yates (JIRA)" <ji...@apache.org> on 2012/05/24 07:50:40 UTC
[jira] [Created] (HBASE-6087) Add hbase-common module
Jesse Yates created HBASE-6087:
----------------------------------
Summary: Add hbase-common module
Key: HBASE-6087
URL: https://issues.apache.org/jira/browse/HBASE-6087
Project: HBase
Issue Type: Bug
Components: build
Affects Versions: 0.96.0
Reporter: Jesse Yates
Assignee: Jesse Yates
Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286257#comment-13286257 ]
Zhihong Yu commented on HBASE-6087:
-----------------------------------
Trunk build #2960 failed:
{code}
testHomePath(org.apache.hadoop.hbase.util.TestProcessBasedCluster): Expected to find slash in jar path <https://builds.apache.org/job/HBase-TRUNK/ws/trunk/hbase-common/target/hbase-common-0.95-SNAPSHOT.jar!>
{code}
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6087) Add hbase-common module
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-6087:
-------------------------------
Attachment: hbase-6087-v0.patch
Attaching first cut. Tested locally and in-situ as well as the packaged version seems to work fine.
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286049#comment-13286049 ]
Jesse Yates commented on HBASE-6087:
------------------------------------
{quote}
Is it possible at all running just the hbase-common unit tests w/o having to run all module tests? If so, do I have to do the invocation from parent dir or can I do it in the hbase-common module? (Like Matt, apologize if I'm being particularly thick on this one).
{quote}
...yeah, I guess we could make the unit tests uncategorized in hbase-common. My immediate reaction was to not change the overall pom and keep the categorization, but since we are planning on doing a separate module (eventually, maybe?) for the integration/cluster tests, it makes sense that we don't need to categorize them.
{quote}
Why is it being moved earlier?
{quote}
It was messing with the classpath stuff. It has something do with the way the modules were being added that it work bork the webapp. This should work into perpetuity.
{quote}
Doesn't this get inherited from parent? "+ <version>0.95-SNAPSHOT</version>" (This is version of the new hbase-common pom.xml).
{quote}
Yeah, I think your right.
{quote}
This comment is wrong?
{quote}
yes.
{quote}
I'm +1 on committing this. Good stuff Jesse. Is it ready to go you think?
{quote}
let me just fix the above and it can go in.
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286247#comment-13286247 ]
Hudson commented on HBASE-6087:
-------------------------------
Integrated in HBase-TRUNK #2960 (See [https://builds.apache.org/job/HBase-TRUNK/2960/])
HBASE-6087 Add hbase-common module (Revision 1344510)
Result = FAILURE
stack :
Files :
* /hbase/trunk/bin/hbase
* /hbase/trunk/hbase-assembly/pom.xml
* /hbase/trunk/hbase-assembly/src/assembly/all.xml
* /hbase/trunk/hbase-common
* /hbase/trunk/hbase-common/pom.xml
* /hbase/trunk/hbase-common/src
* /hbase/trunk/hbase-common/src/main
* /hbase/trunk/hbase-common/src/main/java
* /hbase/trunk/hbase-common/src/main/java/org
* /hbase/trunk/hbase-common/src/main/java/org/apache
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/VersionAnnotation.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/VersionInfo.java
* /hbase/trunk/hbase-server/pom.xml
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HConstants.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/VersionAnnotation.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/Bytes.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/VersionInfo.java
* /hbase/trunk/hbase-site/src/docbkx/developer.xml
* /hbase/trunk/pom.xml
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285979#comment-13285979 ]
stack commented on HBASE-6087:
------------------------------
Why this change in a patch that adds a new module?
{code}
+# For releases, add hbase & webapps to CLASSPATH
+# Webapps must come first else it messes up Jetty
+if [ -d "$HBASE_HOME/hbase-webapps" ]; then
+ add_to_cp_if_exists "${HBASE_HOME}"
+fi
+#add if we are in a dev environment
+if [ -d "$HBASE_HOME/hbase-server/target/hbase-webapps" ]; then
+ add_to_cp_if_exists "${HBASE_HOME}/hbase-server/target"
+fi
{code}
Why is it being moved earlier?
Doesn't this get inherited from parent? "+ <version>0.95-SNAPSHOT</version>" (This is version of the new hbase-common pom.xml).
This comment is wrong?
{code}
+ <!--
+ profile for building against Hadoop 0.23.0. Activate using:
+ mvn -Dhadoop.profile=23
+ -->
{code}
Thats good HBaseConfiguration comes up. HConstants too? That think is an ugly anti-pattern. I'm fine w/ it going up but need to figure how to kill it.
I'm +1 on committing this. Good stuff Jesse. Is it ready to go you think?
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6087) Add hbase-common module
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6087:
-------------------------
Status: Patch Available (was: Open)
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286382#comment-13286382 ]
Jesse Yates commented on HBASE-6087:
------------------------------------
test passed locally with addendum applied.
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6087-addendum-v2.patch, hbase-6087-addendum.patch, hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286058#comment-13286058 ]
Hadoop QA commented on HBASE-6087:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530120/hbase-6087-v1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 10 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2061//testReport/
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2061//console
This message is automatically generated.
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286037#comment-13286037 ]
Zhihong Yu commented on HBASE-6087:
-----------------------------------
In AssignmentManager.java:
{code}
+ public static final ServerName HBCK_CODE_SERVERNAME = new ServerName(HConstants.HBCK_CODE_NAME,
+ -1, -1L);
{code}
Why cannot we use HConstants.HBCK_CODE_SERVERNAME ?
For the files in hbase-common module, it would be nice to remove year in their license header.
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286306#comment-13286306 ]
stack commented on HBASE-6087:
------------------------------
Applied addendum 2. Thanks Jesse.
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6087-addendum-v2.patch, hbase-6087-addendum.patch, hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6087) Add hbase-common module
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6087:
-------------------------
Status: Patch Available (was: Open)
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286302#comment-13286302 ]
Jesse Yates commented on HBASE-6087:
------------------------------------
@Stack: forgot to update the standard profile - currently fails hbase-common if no tests are found (fixed in newer addendum)
@Ted: test seemed to pass locally. I don't know why it failed server side...
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6087-addendum.patch, hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286511#comment-13286511 ]
Hudson commented on HBASE-6087:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #34 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/34/])
HBASE-6087 Add hbase-common module: ADDENDUM (Revision 1344559)
HBASE-6087 Add hbase-common module: ADDENDUM (Revision 1344558)
HBASE-6087 Add hbase-common module (Revision 1344510)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-common/src/test
* /hbase/trunk/hbase-common/src/test/java
* /hbase/trunk/hbase-common/src/test/java/org
* /hbase/trunk/hbase-common/src/test/java/org/apache
* /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop
* /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase
* /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util
* /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java
stack :
Files :
* /hbase/trunk/hbase-common/pom.xml
* /hbase/trunk/hbase-server/pom.xml
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/HBaseHomePath.java
* /hbase/trunk/hbase-site/src/docbkx/developer.xml
* /hbase/trunk/pom.xml
stack :
Files :
* /hbase/trunk/bin/hbase
* /hbase/trunk/hbase-assembly/pom.xml
* /hbase/trunk/hbase-assembly/src/assembly/all.xml
* /hbase/trunk/hbase-common
* /hbase/trunk/hbase-common/pom.xml
* /hbase/trunk/hbase-common/src
* /hbase/trunk/hbase-common/src/main
* /hbase/trunk/hbase-common/src/main/java
* /hbase/trunk/hbase-common/src/main/java/org
* /hbase/trunk/hbase-common/src/main/java/org/apache
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/VersionAnnotation.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/VersionInfo.java
* /hbase/trunk/hbase-server/pom.xml
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HConstants.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/VersionAnnotation.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/Bytes.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/VersionInfo.java
* /hbase/trunk/hbase-site/src/docbkx/developer.xml
* /hbase/trunk/pom.xml
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6087-addendum-v2.patch, hbase-6087-addendum.patch, hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286196#comment-13286196 ]
Hadoop QA commented on HBASE-6087:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530292/hbase-6087-v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2065//testReport/
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2065//console
This message is automatically generated.
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286304#comment-13286304 ]
stack commented on HBASE-6087:
------------------------------
That works. And the test TestSplitLogManager passes for me too. Let me apply addendum 2.
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6087-addendum-v2.patch, hbase-6087-addendum.patch, hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "Matt Corgan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285284#comment-13285284 ]
Matt Corgan commented on HBASE-6087:
------------------------------------
So we should leave all tests in the server package until we figure out a work-around? You've explained the problem before but i haven't quite grasped it. As an example, what would be the problem with pulling up TestBytes.java?
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6087) Add hbase-common module
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6087:
-------------------------
Status: Open (was: Patch Available)
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285266#comment-13285266 ]
Jesse Yates commented on HBASE-6087:
------------------------------------
I'm just moving the category classes into the main code, as opposed to the test code, because maven is broken w.r.t. test package dependence. The only way to test properly then is to run mvn install, which is a huge pain.
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6087) Add hbase-common module
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-6087:
-------------------------------
Attachment: hbase-6087-addendum.patch
Attaching patch to fix that test, as well as the requested move of a test for hbase-commons and an update to the docs. Along with the move, I added the ability to turn off tests for a give module via command-line options (see doc for usage).
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6087-addendum.patch, hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6087) Add hbase-common module
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-6087:
-------------------------------
Attachment: hbase-6087-v2.patch
Attaching updated version. This should fix the test issue (seems to run fine locally), letting you just write regular unit tests in hbase-commons, but still requiring the annotation for tests in hbase-server.
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285288#comment-13285288 ]
Jesse Yates commented on HBASE-6087:
------------------------------------
I would like to leave all the tests in the server package, except surefire runs by default in all non-pom modules. It seems like a better idea to just pull up the couple of used classes (in this case Large/Medium/SmallTest.java, since the plugin actually loads those classes to run tests) than to hack the pom to not run tests. This way if people start writing tests in the new module, they will at least be run (rather than giving a false positive).
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285265#comment-13285265 ]
Jesse Yates commented on HBASE-6087:
------------------------------------
Actually, just kidding. This won't actually pass 'mvn test' because we aren't including the test categories. Have to move those up too - coming soon.
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6087) Add hbase-common module
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-6087:
-------------------------------
Attachment: hbase-6087-v1.patch
Attaching a new patch that seemed to test alright (and ran insitu fine).
I just moved the test categories up to the other module, as opposed to changing the directory to something like org.apache.hadoop.hbase.test, in an attempt to not touch all the test files.
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286295#comment-13286295 ]
stack commented on HBASE-6087:
------------------------------
This don't seem to work any more w/ or w/o the addendum:
{code}
~/bin/mvn/bin/mvn test -PlocalTests -Dtest=TestSplitLogManager
{code}
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6087-addendum.patch, hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286375#comment-13286375 ]
Hudson commented on HBASE-6087:
-------------------------------
Integrated in HBase-TRUNK #2962 (See [https://builds.apache.org/job/HBase-TRUNK/2962/])
HBASE-6087 Add hbase-common module: ADDENDUM (Revision 1344559)
HBASE-6087 Add hbase-common module: ADDENDUM (Revision 1344558)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-common/src/test
* /hbase/trunk/hbase-common/src/test/java
* /hbase/trunk/hbase-common/src/test/java/org
* /hbase/trunk/hbase-common/src/test/java/org/apache
* /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop
* /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase
* /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util
* /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java
stack :
Files :
* /hbase/trunk/hbase-common/pom.xml
* /hbase/trunk/hbase-server/pom.xml
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/HBaseHomePath.java
* /hbase/trunk/hbase-site/src/docbkx/developer.xml
* /hbase/trunk/pom.xml
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6087-addendum-v2.patch, hbase-6087-addendum.patch, hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286280#comment-13286280 ]
Zhihong Yu commented on HBASE-6087:
-----------------------------------
I was able to run TestBytes successfully under hbase-common module.
I ran TestSplitLogManager which failed due to:
{code}
2012-05-30 19:55:07,321 WARN [Thread-15] master.TestSplitLogManager$4(526): splitLogDistributed failed
java.io.IOException: error or interrupt while splitting logs in [file:/home/hduser/trunk/hbase-server/ca60bcb1-ab93-4b5e-8a0c-9fa7bc2b3fab] Task = installed = 1 done = 0 error = 0
at org.apache.hadoop.hbase.master.SplitLogManager.splitLogDistributed(SplitLogManager.java:267)
at org.apache.hadoop.hbase.master.SplitLogManager.splitLogDistributed(SplitLogManager.java:227)
at org.apache.hadoop.hbase.master.TestSplitLogManager$4.run(TestSplitLogManager.java:524)
{code}
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6087-addendum.patch, hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286261#comment-13286261 ]
Jesse Yates commented on HBASE-6087:
------------------------------------
Looking into it... probably because I moved HConstants. Also, almost have the addendum for doing unit tests ready.
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6087) Add hbase-common module
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6087:
-------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Release Note: New module for common base hbase classes.
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks for the patch Jesse.
Jesse, any chance of your adding or porting a test back to hbase-common with a prescription in reference guide or as a release note on how to run unit tests on hbase-common only for the likes of the dummies like myself and Matt?
This is great.
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285974#comment-13285974 ]
stack commented on HBASE-6087:
------------------------------
bq.... except surefire runs by default in all non-pom modules.
I don't grok the above.
Is it possible at all running just the hbase-common unit tests w/o having to run all module tests? If so, do I have to do the invocation from parent dir or can I do it in the hbase-common module? (Like Matt, apologize if I'm being particularly thick on this one).
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "Matt Corgan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286171#comment-13286171 ]
Matt Corgan commented on HBASE-6087:
------------------------------------
Ok, so i can pull up simple unit tests were appropriate as well? Should they have the SmallTests annotation or no annotation?
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286172#comment-13286172 ]
stack commented on HBASE-6087:
------------------------------
Looks good. Waiting on hadoopqa.
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6087) Add hbase-common module
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286123#comment-13286123 ]
Jesse Yates commented on HBASE-6087:
------------------------------------
{quote}
Why cannot we use HConstants.HBCK_CODE_SERVERNAME ?
{quote}
I'm moved it down because would then need to bring along ServerName, which then brings along org.apache.hadoop.hbase.protobuf.ProtobufUtil and org.apache.hadoop.hbase.protobuf.generated.ZooKeeperProtos.RootRegionServer, which seemed kind of excessive. And for modularization and breaking the HConstants anti-pattern, it makes more sense to just move it into AssignmentManager (the only place that actually references that value).
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6087) Add hbase-common module
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-6087:
-------------------------------
Attachment: hbase-6087-addendum-v2.patch
Attaching patch to allow 'mvn clean test -Dtest=... -P localTests' to still work + previous addendum.
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6087-addendum-v2.patch, hbase-6087-addendum.patch, hbase-6087-v0.patch, hbase-6087-v1.patch, hbase-6087-v2.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of hbase-server. This is _not_ the moving of classes, just the general project setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira