[GitHub] [fluo-muchos] keith-turner commented on a change in pull request #270: Support Accumulo installs on Microsoft Azure

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #270: Support Accumulo installs on Microsoft Azure
URL: https://github.com/apache/fluo-muchos/pull/270#discussion_r321446258
 
 

 ##########
 File path: conf/muchos.props.example
 ##########
 @@ -108,6 +108,29 @@ profile=perf-small
 # Below are different performance profiles that can be selected.  Each profile
 # has the same properties with different values.
 
+[azure]
 
 Review comment:
   I think it would be nice to add some comments to the props in this section.  I took a stab at this and found I had some questions in the process.  My questions are intermingled.
   
   ```
   [azure]
   # The name of an Azure resource group to create.  All resources are created
   # within this group. Question, what happens when it already exists?  
   resource_group = accumulo-rg
   # The name of an Azure virtual network that will be created. Question is it
   # ok if this already exist in the RG?
   vnet = vnet1
   # The CIDR prefix used to create the virtual network. 
   vnet_cidr = "10.0.0.0/8"
   # A single subnet is created within the virtual network and given the 
   # following name.
   subnet = subnet1
   # The CIDR prefix used for the single subnet within the virtual network.
   subnet_cidr = "10.1.0.0/16"
   # A virtual machine scale set with this many VMs will be created.  
   # Question, what is the minimum allowed?  Seems like at lest three are 
   # needed looking at create_vmss.yml 
   numnodes = 8
   # The size of each virtual machine.  See  the following like for other sizes :
   # https://docs.microsoft.com/en-us/azure/virtual-machines/linux/sizes-general
   # Question, should this prop be vm_size instead of vm_sku?
   vm_sku = Standard_D8s_v3
   # Each VM will have the following type of managed disk
   managed_disk_type = Standard_LRS
   # Number of managed disk to create on each VM.
   numdisks = 3
   # The size of each managed disk in a VM.
   disk_size_gb = 128
   # All managed disk will be mounted at this location in each VM
   mount_root = /var/data
   # What is this?
   metrics_drive_root = var-data
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services