[GitHub] [guacamole-client] mike-jumper commented on a change in pull request #457: GUACAMOLE-550: Add autocomplete attributes to applicable form fields.

[GitBox <gi...@apache.org>]

mike-jumper commented on a change in pull request #457: GUACAMOLE-550: Add autocomplete attributes to applicable form fields.
URL: https://github.com/apache/guacamole-client/pull/457#discussion_r370976366
 
 

 ##########
 File path: guacamole/src/main/webapp/app/form/templates/dateField.html
 ##########
 @@ -8,5 +8,6 @@
            guac-focus="focused"
            placeholder="{{'FORM.FIELD_PLACEHOLDER_DATE' | translate}}"
            autocorrect="off"
-           autocapitalize="off"/>
+           autocapitalize="off"
+           autocomplete="off"/>
 
 Review comment:
   Any idea whether these input fields will also need proper `name` attributes for browser autocomplete to function reliably?
   
   The MDN article on disabling autocomplete across the board has a section at the bottom titled ["Tools for disabling autocompletion"](Tools_for_disabling_autocompletion) which seems to imply that the `name` attribute plays an important role:
   
   > ## Tools for disabling autocompletion
   >
   > The [`jquery.disableAutoFill`](https://terrylinooo.github.io/jquery.disableAutoFill/) plugin randomizes an input's `name` attribute by default. When the form is submitted, the plugin restores the original name. This prevents auto-completion for all browsers (includes third-party auto-completion extensions) but doesn't necessarily help with login fields.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services