You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/30 11:46:43 UTC

[GitHub] [hbase] Apache9 commented on a change in pull request #2324: HBASE-24937 table.rb use LocalDateTime to replace Instant

Apache9 commented on a change in pull request #2324:
URL: https://github.com/apache/hbase/pull/2324#discussion_r479759503



##########
File path: hbase-shell/src/main/ruby/hbase/table.rb
##########
@@ -750,8 +750,9 @@ def parse_column_name(column)
       [spec.family, spec.qualifier]
     end
 
-    def toISO8601(millis)
-      return java.time.Instant.ofEpochMilli(millis).toString
+    def toLocalDateTime(millis)
+      instant = java.time.Instant.ofEpochMilli(millis).toString

Review comment:
       Do we still need the toString?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org