You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/11/02 16:01:57 UTC
[PR] [SPARK-45771][CORE] Enable spark.eventLog.rolling.enabled by default [spark]
dongjoon-hyun opened a new pull request, #43638:
URL: https://github.com/apache/spark/pull/43638
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45771][CORE] Enable `spark.eventLog.rolling.enabled` by default [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43638:
URL: https://github.com/apache/spark/pull/43638#issuecomment-1791433846
AppVeyor failure (SparkR) is irrelevant to this PR.
Could you review this PR when you have some time, @viirya?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45771][CORE] Enable `spark.eventLog.rolling.enabled` by default [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #43638:
URL: https://github.com/apache/spark/pull/43638#discussion_r1380456215
##########
core/src/test/scala/org/apache/spark/deploy/history/EventLogTestHelper.scala:
##########
@@ -38,6 +38,7 @@ object EventLogTestHelper {
def getLoggingConf(logDir: Path, compressionCodec: Option[String] = None): SparkConf = {
val conf = new SparkConf
conf.set(EVENT_LOG_ENABLED, true)
+ conf.set(EVENT_LOG_ENABLE_ROLLING, false)
Review Comment:
This is consistent with the existing function description.
https://github.com/apache/spark/blob/5970d353360d4fb6647c8fbc10f733abf009eca1/core/src/test/scala/org/apache/spark/deploy/history/EventLogTestHelper.scala#L35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45771][CORE] Enable `spark.eventLog.rolling.enabled` by default [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #43638:
URL: https://github.com/apache/spark/pull/43638#issuecomment-1791474994
Oh, got it, existing one looks good. From the diff, I cannot see it so I thought `SingleEventLogFileWriter` isn't tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45771][CORE] Enable `spark.eventLog.rolling.enabled` by default [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #43638:
URL: https://github.com/apache/spark/pull/43638#discussion_r1380703869
##########
core/src/test/scala/org/apache/spark/deploy/history/EventLogFileWritersSuite.scala:
##########
@@ -66,7 +66,7 @@ abstract class EventLogFileWritersSuite extends SparkFunSuite with LocalSparkCon
conf.set(EVENT_LOG_DIR, testDir.toString)
// default config
- buildWriterAndVerify(conf, classOf[SingleEventLogFileWriter])
+ buildWriterAndVerify(conf, classOf[RollingEventLogFilesWriter])
conf.set(EVENT_LOG_ENABLE_ROLLING, true)
Review Comment:
Is it redundant then?
```suggestion
conf.set(EVENT_LOG_ENABLE_ROLLING, true)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45771][CORE] Enable `spark.eventLog.rolling.enabled` by default [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #43638:
URL: https://github.com/apache/spark/pull/43638#discussion_r1380705437
##########
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala:
##########
@@ -163,6 +163,7 @@ class EventLoggingListenerSuite extends SparkFunSuite with LocalSparkContext wit
test("SPARK-31764: isBarrier should be logged in event log") {
val conf = new SparkConf()
conf.set(EVENT_LOG_ENABLED, true)
+ conf.set(EVENT_LOG_ENABLE_ROLLING, false)
Review Comment:
Is it failed without setting to false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45771][CORE] Enable `spark.eventLog.rolling.enabled` by default [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #43638:
URL: https://github.com/apache/spark/pull/43638#discussion_r1380704238
##########
core/src/test/scala/org/apache/spark/deploy/history/EventLogFileWritersSuite.scala:
##########
@@ -66,7 +66,7 @@ abstract class EventLogFileWritersSuite extends SparkFunSuite with LocalSparkCon
conf.set(EVENT_LOG_DIR, testDir.toString)
// default config
- buildWriterAndVerify(conf, classOf[SingleEventLogFileWriter])
+ buildWriterAndVerify(conf, classOf[RollingEventLogFilesWriter])
conf.set(EVENT_LOG_ENABLE_ROLLING, true)
buildWriterAndVerify(conf, classOf[RollingEventLogFilesWriter])
Review Comment:
```suggestion
```
##########
core/src/test/scala/org/apache/spark/deploy/history/EventLogFileWritersSuite.scala:
##########
@@ -66,7 +66,7 @@ abstract class EventLogFileWritersSuite extends SparkFunSuite with LocalSparkCon
conf.set(EVENT_LOG_DIR, testDir.toString)
// default config
- buildWriterAndVerify(conf, classOf[SingleEventLogFileWriter])
+ buildWriterAndVerify(conf, classOf[RollingEventLogFilesWriter])
conf.set(EVENT_LOG_ENABLE_ROLLING, true)
Review Comment:
Is it redundant then?
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45771][CORE] Enable `spark.eventLog.rolling.enabled` by default [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #43638:
URL: https://github.com/apache/spark/pull/43638#discussion_r1380713182
##########
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala:
##########
@@ -163,6 +163,7 @@ class EventLoggingListenerSuite extends SparkFunSuite with LocalSparkContext wit
test("SPARK-31764: isBarrier should be logged in event log") {
val conf = new SparkConf()
conf.set(EVENT_LOG_ENABLED, true)
+ conf.set(EVENT_LOG_ENABLE_ROLLING, false)
Review Comment:
Yes, this test case tries to read the event log file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45771][CORE] Enable `spark.eventLog.rolling.enabled` by default [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43638:
URL: https://github.com/apache/spark/pull/43638#issuecomment-1791468911
Just for your confirmation. I keep the existing test structure.
```
buildWriterAndVerify(conf, classOf[RollingEventLogFilesWriter])
conf.set(EVENT_LOG_ENABLE_ROLLING, true)
buildWriterAndVerify(conf, classOf[RollingEventLogFilesWriter])
conf.set(EVENT_LOG_ENABLE_ROLLING, false)
buildWriterAndVerify(conf, classOf[SingleEventLogFileWriter])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45771][CORE] Enable `spark.eventLog.rolling.enabled` by default [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #43638:
URL: https://github.com/apache/spark/pull/43638#discussion_r1380704945
##########
core/src/test/scala/org/apache/spark/deploy/history/EventLogFileWritersSuite.scala:
##########
@@ -66,7 +66,7 @@ abstract class EventLogFileWritersSuite extends SparkFunSuite with LocalSparkCon
conf.set(EVENT_LOG_DIR, testDir.toString)
// default config
- buildWriterAndVerify(conf, classOf[SingleEventLogFileWriter])
+ buildWriterAndVerify(conf, classOf[RollingEventLogFilesWriter])
conf.set(EVENT_LOG_ENABLE_ROLLING, true)
Review Comment:
Or we want to:
```suggestion
conf.set(EVENT_LOG_ENABLE_ROLLING, false)
buildWriterAndVerify(conf, classOf[SingleEventLogFileWriter])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45771][CORE] Enable `spark.eventLog.rolling.enabled` by default [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43638:
URL: https://github.com/apache/spark/pull/43638#issuecomment-1791475462
Thank you for your confirmation! Merged to master for Apache Spark 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45771][CORE] Enable `spark.eventLog.rolling.enabled` by default [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #43638: [SPARK-45771][CORE] Enable `spark.eventLog.rolling.enabled` by default
URL: https://github.com/apache/spark/pull/43638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org