You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by riknoll <gi...@git.apache.org> on 2016/03/02 02:47:45 UTC

[GitHub] cordova-plugin-media-capture pull request: Fixing README for displ...

GitHub user riknoll opened a pull request:

    https://github.com/apache/cordova-plugin-media-capture/pull/58

    Fixing README for display on Cordova website

    I moved some stuff around because it looked awkward in the TOC for the page. See [here](http://cordova.apache.org/docs/en/dev/cordova-plugin-media-capture/index.html)
    
    @dblotsky @rakatyal to review

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-media-capture website-readme-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media-capture/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #58
    
----
commit 5c644f0ffdf134449bf443b0e254ab7c294359b8
Author: riknoll <ri...@gmail.com>
Date:   2016-03-02T01:26:53Z

    Fixing README for display on Cordova website

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-media-capture pull request: Fixing README for displ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-media-capture/pull/58


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-media-capture pull request: Fixing README for displ...

Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-media-capture/pull/58#discussion_r54668668
  
    --- Diff: README.md ---
    @@ -340,6 +285,61 @@ capturing a video clip, the `CaptureErrorCB` callback executes with a
     - Cordova for BlackBerry 10 attempts to launch the __Video Recorder__ application, provided by RIM, to capture video recordings. The app receives a `CaptureError.CAPTURE_NOT_SUPPORTED` error code if the application is not installed on the device.
     
     
    +## CaptureAudioOptions
    +
    +> Encapsulates audio capture configuration options.
    --- End diff --
    
    Nitpick: This doesn't need to be a quote.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-media-capture pull request: Fixing README for displ...

Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:

    https://github.com/apache/cordova-plugin-media-capture/pull/58#issuecomment-191501509
  
    LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-media-capture pull request: Fixing README for displ...

Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-media-capture/pull/58#discussion_r54668778
  
    --- Diff: README.md ---
    @@ -340,6 +285,61 @@ capturing a video clip, the `CaptureErrorCB` callback executes with a
     - Cordova for BlackBerry 10 attempts to launch the __Video Recorder__ application, provided by RIM, to capture video recordings. The app receives a `CaptureError.CAPTURE_NOT_SUPPORTED` error code if the application is not installed on the device.
     
     
    +## CaptureAudioOptions
    +
    +> Encapsulates audio capture configuration options.
    +
    +### Properties
    +
    +- __limit__: The maximum number of audio clips the device user can record in a single capture operation.  The value must be greater than or equal to 1 (defaults to 1).
    +
    +- __duration__: The maximum duration of an audio sound clip, in seconds.
    +
    +### Example
    +
    +    // limit capture operation to 3 media files, no longer than 10 seconds each
    +    var options = { limit: 3, duration: 10 };
    +
    +    navigator.device.capture.captureAudio(captureSuccess, captureError, options);
    +
    +### Amazon Fire OS Quirks
    +
    +- The `duration` parameter is not supported.  Recording lengths cannot be limited programmatically.
    +
    +### Android Quirks
    +
    +- The `duration` parameter is not supported.  Recording lengths can't be limited programmatically.
    +
    +### BlackBerry 10 Quirks
    +
    +- The `duration` parameter is not supported.  Recording lengths can't be limited programmatically.
    +- The `limit` parameter is not supported, so only one recording can be created for each invocation.
    +
    +### iOS Quirks
    +
    +- The `limit` parameter is not supported, so only one recording can be created for each invocation.
    +
    +
    +## CaptureImageOptions
    +
    +> Encapsulates image capture configuration options.
    --- End diff --
    
    Nitpick: This doesn't need to be a quote.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-media-capture pull request: Fixing README for displ...

Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:

    https://github.com/apache/cordova-plugin-media-capture/pull/58#issuecomment-191447457
  
    Can I merge this one? The quotes are just formatting that is used through the rest of the file, so I'd rather not update it unless we are making all of the plugin READMEs have consistent formatting


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org