You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2024/02/14 22:44:01 UTC
[PR] Add sensible scalac options [incubator-pekko-sbt-paradox]
mdedetrich opened a new pull request, #100:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/100
Self explanatory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add sensible scalac options [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/100#discussion_r1490160200
##########
build.sbt:
##########
@@ -104,3 +104,20 @@ ThisBuild / githubWorkflowOSes := Seq("ubuntu-latest", "macos-latest", "windows-
ThisBuild / githubWorkflowJavaVersions := Seq(
JavaSpec.temurin("8"))
+
+ThisBuild / scalacOptions ++= List(
+ "-unchecked",
+ "-deprecation",
+ "-language:_",
+ "-encoding",
+ "UTF-8")
+
+ThisBuild / scalacOptions ++= {
+ if (insideCI.value) {
+ val log = sLog.value
Review Comment:
Forgot about this, will be handled by our sbt plugin. Removing now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add sensible scalac options [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #100:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add sensible scalac options [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/100#discussion_r1490160457
##########
build.sbt:
##########
@@ -104,3 +104,20 @@ ThisBuild / githubWorkflowOSes := Seq("ubuntu-latest", "macos-latest", "windows-
ThisBuild / githubWorkflowJavaVersions := Seq(
JavaSpec.temurin("8"))
+
+ThisBuild / scalacOptions ++= List(
+ "-unchecked",
+ "-deprecation",
+ "-language:_",
+ "-encoding",
+ "UTF-8")
+
+ThisBuild / scalacOptions ++= {
+ if (insideCI.value) {
+ val log = sLog.value
Review Comment:
@pjfanning Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add sensible scalac options [incubator-pekko-sbt-paradox]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/100#discussion_r1490158467
##########
build.sbt:
##########
@@ -104,3 +104,20 @@ ThisBuild / githubWorkflowOSes := Seq("ubuntu-latest", "macos-latest", "windows-
ThisBuild / githubWorkflowJavaVersions := Seq(
JavaSpec.temurin("8"))
+
+ThisBuild / scalacOptions ++= List(
+ "-unchecked",
+ "-deprecation",
+ "-language:_",
+ "-encoding",
+ "UTF-8")
+
+ThisBuild / scalacOptions ++= {
+ if (insideCI.value) {
+ val log = sLog.value
Review Comment:
how about when a human needs to release this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org